[flutter_markdown] Fix table column alignment #7327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please resolve conflicts |
tarrinneal
approved these changes
Aug 8, 2024
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 8, 2024
flutter/packages@5cc0a01...bb797b9 2024-08-08 [email protected] [google_maps_flutter] Converts map configuration and platform view creation params to Pigeon (flutter/packages#7207) 2024-08-08 [email protected] [flutter_markdown] Fix table column alignment (flutter/packages#7327) 2024-08-08 [email protected] [interactive_media_ads] Fix names of unit tests (flutter/packages#7336) 2024-08-07 [email protected] [url_launcher] Convert Linux to Pigeon (flutter/packages#7215) 2024-08-07 [email protected] Roll Flutter from 0a7f8af to d595e98 (4 revisions) (flutter/packages#7334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
flutter/packages@5cc0a01...bb797b9 2024-08-08 [email protected] [google_maps_flutter] Converts map configuration and platform view creation params to Pigeon (flutter/packages#7207) 2024-08-08 [email protected] [flutter_markdown] Fix table column alignment (flutter/packages#7327) 2024-08-08 [email protected] [interactive_media_ads] Fix names of unit tests (flutter/packages#7336) 2024-08-07 [email protected] [url_launcher] Convert Linux to Pigeon (flutter/packages#7215) 2024-08-07 [email protected] Roll Flutter from 0a7f8af to d595e98 (4 revisions) (flutter/packages#7334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@5cc0a01...bb797b9 2024-08-08 [email protected] [google_maps_flutter] Converts map configuration and platform view creation params to Pigeon (flutter/packages#7207) 2024-08-08 [email protected] [flutter_markdown] Fix table column alignment (flutter/packages#7327) 2024-08-08 [email protected] [interactive_media_ads] Fix names of unit tests (flutter/packages#7336) 2024-08-07 [email protected] [url_launcher] Convert Linux to Pigeon (flutter/packages#7215) 2024-08-07 [email protected] Roll Flutter from 0a7f8af to d595e98 (4 revisions) (flutter/packages#7334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
… wraps (#8340) This PR complements PR #7327 (Fix table column alignment), making the table column custom alignment keep working even when text wraps. Ironically, setting `Wrap.alignment` wasn't enough, we needed to correct each `Text.textAlign` in the function `_mergeInlineChildren()`. Basically, this PR is a major refactor of said function, ensuring that the loop runs to completion even when there is a single widget in the children (thus remaking the widget with the correct `textAlign`). This fixes flutter/flutter#160746.
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
… wraps (flutter#8340) This PR complements PR flutter#7327 (Fix table column alignment), making the table column custom alignment keep working even when text wraps. Ironically, setting `Wrap.alignment` wasn't enough, we needed to correct each `Text.textAlign` in the function `_mergeInlineChildren()`. Basically, this PR is a major refactor of said function, ensuring that the loop runs to completion even when there is a single widget in the children (thus remaking the widget with the correct `textAlign`). This fixes flutter/flutter#160746.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
… wraps (flutter#8340) This PR complements PR flutter#7327 (Fix table column alignment), making the table column custom alignment keep working even when text wraps. Ironically, setting `Wrap.alignment` wasn't enough, we needed to correct each `Text.textAlign` in the function `_mergeInlineChildren()`. Basically, this PR is a major refactor of said function, ensuring that the loop runs to completion even when there is a single widget in the children (thus remaking the widget with the correct `textAlign`). This fixes flutter/flutter#160746.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue: flutter/flutter#109487. This fix applies the appropriate
alignmentproperty toWrapdepending on thetextAlign.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.