[google_maps_flutter_android] Android changes to support heatmaps #7313

Rexios80 · 2024-08-05T15:55:38Z

Sequel to:

[google_maps_flutter_platform_interface] Platform interface changes to support heatmaps #7312

Prequel to:

[google_maps_flutter] Add heatmap support #3257

stuartmorgan-g

The platform implementation PRs need to wait for the platform interface PR to land and be published before they are reviewable, since the state of the PR right now isn't what will land.

…o support heatmaps (#7312) Prequel to: - #7313 - #7314 - #7315 - #3257

…droid

Rexios80 · 2024-08-05T22:39:43Z

@reidbaker
I get this error with @Config(minSdk = Build.VERSION_CODES.LOLLIPOP) but not with @Config(sdk = Build.VERSION_CODES.P)

Error

Failed to load /Users/rexios/.m2/repository/org/robolectric/android-all-instrumented/13-robolectric-9030017-i4/android-all-instrumented-13-robolectric-9030017-i4.jar
java.lang.OutOfMemoryError: Failed to load /Users/rexios/.m2/repository/org/robolectric/android-all-instrumented/13-robolectric-9030017-i4/android-all-instrumented-13-robolectric-9030017-i4.jar
	at org.robolectric.shadows.ShadowArscApkAssets9.nativeLoad(ShadowArscApkAssets9.java:275)
	at org.robolectric.shadows.ShadowArscApkAssets9.nativeLoad(ShadowArscApkAssets9.java:293)
	at android.content.res.ApkAssets.nativeLoad(ApkAssets.java)
	at android.content.res.ApkAssets.__constructor__(ApkAssets.java:296)
	at android.content.res.ApkAssets.<init>(ApkAssets.java)
	at android.content.res.ApkAssets.loadFromPath(ApkAssets.java:145)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at org.robolectric.shadows.ShadowArscApkAssets9$_ApkAssets_$$Reflector395.loadFromPath(Unknown Source)
	at org.robolectric.shadows.ShadowArscApkAssets9.lambda$loadFromPath$3(ShadowArscApkAssets9.java:239)
	at org.robolectric.shadows.ShadowArscApkAssets9.getFromCacheOrLoad(ShadowArscApkAssets9.java:178)
	at org.robolectric.shadows.ShadowArscApkAssets9.loadFromPath(ShadowArscApkAssets9.java:237)
	at android.content.res.ApkAssets.loadFromPath(ApkAssets.java)
	at android.content.res.AssetManager.createSystemAssetsInZygoteLocked(AssetManager.java:249)
	at android.content.res.AssetManager.getSystem(AssetManager.java:276)
	at org.robolectric.shadows.ShadowResources.getSystem(ShadowResources.java:83)
	at android.content.res.Resources.getSystem(Resources.java)
	at org.robolectric.android.internal.RoboMonitoringInstrumentation.onCreate(RoboMonitoringInstrumentation.java:74)
	at org.robolectric.android.internal.AndroidTestEnvironment.createInstrumentation(AndroidTestEnvironment.java:582)
	at org.robolectric.android.internal.AndroidTestEnvironment.setUpApplicationState(AndroidTestEnvironment.java:205)
	at org.robolectric.RobolectricTestRunner.beforeTest(RobolectricTestRunner.java:340)
	at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$2(SandboxTestRunner.java:281)
	at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:99)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.OutOfMemoryError: Java heap space
	at org.robolectric.res.android.FileMap.getDataPtr(FileMap.java:413)
	at org.robolectric.res.android.Asset$_CompressedAsset.getBuffer(Asset.java:1338)
	at org.robolectric.res.android.CppApkAssets.LoadImpl_measured(CppApkAssets.java:259)
	at org.robolectric.res.android.CppApkAssets.lambda$LoadImpl$0(CppApkAssets.java:206)
	at org.robolectric.res.android.CppApkAssets$$Lambda$441/0x00000008005bec50.get(Unknown Source)
	at org.robolectric.util.PerfStatsCollector.measure(PerfStatsCollector.java:53)
	at org.robolectric.res.android.CppApkAssets.LoadImpl(CppApkAssets.java:203)
	at org.robolectric.res.android.CppApkAssets.Load(CppApkAssets.java:117)
	at org.robolectric.shadows.ShadowArscApkAssets9.nativeLoad(ShadowArscApkAssets9.java:272)
	at org.robolectric.shadows.ShadowArscApkAssets9.nativeLoad(ShadowArscApkAssets9.java:293)
	at java.base/java.lang.invoke.DirectMethodHandle$Holder.invokeStatic(Unknown Source)
	at java.base/java.lang.invoke.LambdaForm$MH/0x0000000802225800.invoke(LambdaForm$MH)
	at java.base/java.lang.invoke.LambdaForm$MH/0x00000008019a6000.reinvoke(LambdaForm$MH)
	at java.base/java.lang.invoke.LambdaForm$MH/0x00000008019a6400.guard(LambdaForm$MH)
	at java.base/java.lang.invoke.LambdaForm$MH/0x00000008019a6800.linkToCallSite(LambdaForm$MH)
	at android.content.res.ApkAssets.nativeLoad(ApkAssets.java)
	at android.content.res.ApkAssets.$$robo$$android_content_res_ApkAssets$__constructor__(ApkAssets.java:296)
	at java.base/java.lang.invoke.LambdaForm$DMH/0x000000080199e400.invokeSpecial(LambdaForm$DMH)
	at java.base/java.lang.invoke.LambdaForm$MH/0x00000008019a0400.guardWithCatch(LambdaForm$MH)
	at java.base/java.lang.invoke.LambdaForm$MH/0x00000008019a2400.reinvoke(LambdaForm$MH)
	at java.base/java.lang.invoke.LambdaForm$MH/0x00000008019a2800.guard(LambdaForm$MH)
	at java.base/java.lang.invoke.LambdaForm$MH/0x00000008019a2c00.linkToCallSite(LambdaForm$MH)
	at android.content.res.ApkAssets.<init>(ApkAssets.java)
	at android.content.res.ApkAssets.$$robo$$android_content_res_ApkAssets$loadFromPath(ApkAssets.java:145)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
	at org.robolectric.shadows.ShadowArscApkAssets9$_ApkAssets_$$Reflector395.loadFromPath(Unknown Source)
	at org.robolectric.shadows.ShadowArscApkAssets9.lambda$loadFromPath$3(ShadowArscApkAssets9.java:239)
	at org.robolectric.shadows.ShadowArscApkAssets9$$Lambda$803/0x000000080221bce8.call(Unknown Source)
	at org.robolectric.shadows.ShadowArscApkAssets9.getFromCacheOrLoad(ShadowArscApkAssets9.java:178)

reidbaker · 2024-08-05T22:41:16Z

Feel free to leave as targeting p. We will figure it out after your pr lands

stuartmorgan-g

LGTM

…maps (flutter/packages#7313)

flutter/packages@82e8d1e...551bde5 2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317) 2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315) 2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314) 2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313) 2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012) 2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280) 2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278) 2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312) 2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288) 2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…o support heatmaps (flutter#7312) Prequel to: - flutter#7313 - flutter#7314 - flutter#7315 - flutter#3257

…o support heatmaps (#7312) Prequel to: - flutter/packages#7313 - flutter/packages#7314 - flutter/packages#7315 - flutter/packages#3257

Rexios80 added 2 commits August 5, 2024 11:45

Platform interface changes to support heatmaps

6875cee

Android changes to support heatmaps

57a8062

Rexios80 requested review from reidbaker and stuartmorgan-g as code owners August 5, 2024 15:55

github-actions bot added p: google_maps_flutter platform-android labels Aug 5, 2024

reidbaker approved these changes Aug 5, 2024

View reviewed changes

Rexios80 mentioned this pull request Aug 5, 2024

[google_maps_flutter_platform_interface] Platform interface changes to support heatmaps #7312

Merged

Merge branch 'main' into feature/heatmaps-android

bb5be3a

stuartmorgan-g requested changes Aug 5, 2024

View reviewed changes

Rexios80 marked this pull request as draft August 5, 2024 17:01

auto-submit bot pushed a commit that referenced this pull request Aug 5, 2024

[google_maps_flutter_platform_interface] Platform interface changes t…

9308857

…o support heatmaps (#7312) Prequel to: - #7313 - #7314 - #7315 - #3257

Merge with google_maps_flutter PR

c57e4eb

Rexios80 marked this pull request as ready for review August 5, 2024 21:03

Rexios80 added 3 commits August 5, 2024 17:06

Merge remote-tracking branch 'upstream/main' into feature/heatmaps-an…

44f572f

…droid

Revert platform interface changes

4a99369

Remove dependency_overrides

0264ef0

Fix tests

08231a1

Rexios80 requested review from reidbaker and stuartmorgan-g August 5, 2024 22:55

reidbaker approved these changes Aug 5, 2024

View reviewed changes

stuartmorgan-g approved these changes Aug 6, 2024

View reviewed changes

Rexios80 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

auto-submit bot merged commit 89d28fd into flutter:main Aug 6, 2024

engine-flutter-autoroll mentioned this pull request Aug 6, 2024

Roll Packages from 82e8d1eecb45 to 551bde53f6ea (12 revisions) flutter/flutter#152930

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2024

89d28fd [google_maps_flutter_android] Android changes to support heat…

b6b5557

…maps (flutter/packages#7313)

reidbaker mentioned this pull request Aug 6, 2024

[google_maps_android] Update robolectric tests to run against minSdk version instead of sdk and lower that sdk version to the oldest supported. flutter/flutter#152931

Closed

iandis pushed a commit to iandis/flutter-packages that referenced this pull request May 23, 2025

[google_maps_flutter_platform_interface] Platform interface changes t…

430be0d

…o support heatmaps (flutter#7312) Prequel to: - flutter#7313 - flutter#7314 - flutter#7315 - flutter#3257

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[google_maps_flutter_android] Android changes to support heatmaps #7313

[google_maps_flutter_android] Android changes to support heatmaps #7313

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

reidbaker commented Aug 5, 2024

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[google_maps_flutter_android] Android changes to support heatmaps #7313

[google_maps_flutter_android] Android changes to support heatmaps #7313

Uh oh!

Conversation

Rexios80 commented Aug 5, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

reidbaker commented Aug 5, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants