Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Updates all Windows platform implementation packages to use the latest version of Pigeon. The main motivation was picking up the enum naming fix, but I figured I'd do all of them at once, even if they didn't use enums.

Pre-launch Checklist

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Generated files rslgtm. The linter is complaining about an unnecessary default arg (value passed is same as default).

LGTM stamp from a Japanese personal seal

@stuartmorgan-g
Copy link
Collaborator Author

Whoops, I thought I opened everything locally to check for Dart issues. I probably missed a 'pub get' in that package so didn't get real analysis.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2024
@auto-submit auto-submit bot merged commit e978e06 into flutter:main Jul 22, 2024
@stuartmorgan-g stuartmorgan-g deleted the windows-pigeon-mass-update branch July 22, 2024 14:13
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 22, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 22, 2024
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants