[go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart #6670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
reviewed
May 9, 2024
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
Can you update version and change log so that this can be published to pub dev?
altynbek132
force-pushed
the
pr_url_fix
branch
2 times, most recently
from
84868a0 to
0505d5c
Compare
Contributor
Author
@chunhtai done |
|
i am using gorouter with bottomnavigation |
chunhtai
reviewed
May 16, 2024
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, can you rebase again? this package has a lot of traffic
Contributor
Author
|
@chunhtai rebased |
Member
|
Hi, can you rebase again and you also update the version number in pubspec.yaml |
…for push_with_shell_route.dart
…h fix for URL in `navigation.md`
Contributor
Author
|
@Hangyujin @chunhtai done |
chunhtai
added
the
autosubmit
ThangVuNguyenViet
pushed a commit
to ThangVuNguyenViet/packages
that referenced
this pull request
May 29, 2024
…for push_with_shell_route.dart (flutter#6670) [go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2024
…le path for push_with_shell_route.dart (flutter/packages#6670)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 29, 2024
flutter/packages@a933c30...31d3329 2024-05-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.22 to 2.0.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#6815) 2024-05-28 [email protected] [google_maps_flutter] Implement polyline patterns in google maps ios (flutter/packages#5757) 2024-05-28 [email protected] [many] Remove references to v1 embedding (flutter/packages#6494) 2024-05-28 [email protected] [go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart (flutter/packages#6670) 2024-05-28 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.10.0 to 1.11.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#6805) 2024-05-28 [email protected] Roll Flutter from 0b31ffc to a1a33e6 (6 revisions) (flutter/packages#6822) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
flutter/packages@a933c30...31d3329 2024-05-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.22 to 2.0.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#6815) 2024-05-28 [email protected] [google_maps_flutter] Implement polyline patterns in google maps ios (flutter/packages#5757) 2024-05-28 [email protected] [many] Remove references to v1 embedding (flutter/packages#6494) 2024-05-28 [email protected] [go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart (flutter/packages#6670) 2024-05-28 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.10.0 to 1.11.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#6805) 2024-05-28 [email protected] Roll Flutter from 0b31ffc to a1a33e6 (6 revisions) (flutter/packages#6822) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.