[two_dimensional_scrollables] Refactor Spans for common use #6550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
the
p: two_dimensional_scrollables
goderbauer
reviewed
Apr 16, 2024
packages/two_dimensional_scrollables/lib/src/common/implementation_span.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/common/implementation_span.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/common/implementation_span.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/common/implementation_span.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/common/implementation_span.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/common/implementation_span.dart
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2024
flutter/packages@d39830e...0e3809d 2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562) 2024-04-18 [email protected] [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551) 2024-04-17 [email protected] [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550) 2024-04-17 [email protected] [in_app_purchase] Add api to expose country code (flutter/packages#6540) 2024-04-17 [email protected] [camera] Initial iOS Pigeon conversion (flutter/packages#6553) 2024-04-17 [email protected] [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556) 2024-04-17 [email protected] [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404) 2024-04-17 [email protected] [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548) 2024-04-17 [email protected] [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@d39830e...0e3809d 2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562) 2024-04-18 [email protected] [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551) 2024-04-17 [email protected] [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550) 2024-04-17 [email protected] [in_app_purchase] Add api to expose country code (flutter/packages#6540) 2024-04-17 [email protected] [camera] Initial iOS Pigeon conversion (flutter/packages#6553) 2024-04-17 [email protected] [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556) 2024-04-17 [email protected] [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404) 2024-04-17 [email protected] [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548) 2024-04-17 [email protected] [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…6550) This relocates most of `table_span.dart` to `../common/span.dart`, renaming the classes to basic Spans instead of TableSpans. This is because since a Span can represent a row or a column, the new base Span class will be used to build TreeRows in the upcoming TreeView. In `table_span.dart`, the old classes are now typedefs. This is because (IMO) the Table and Tree APIs are better to work with when the naming conventions reflect what you are building. The Table and Tree uses of Span could also deviate in the future and it felt prudent to leave room for future changes that may be specific to only one or the other. Otherwise a bit of tidying to get ready for TreeView! Part of flutter/flutter#42332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relocates most of
table_span.dartto../common/span.dart, renaming the classes to basic Spans instead of TableSpans.This is because since a Span can represent a row or a column, the new base Span class will be used to build TreeRows in the upcoming TreeView.
In
table_span.dart, the old classes are now typedefs. This is because (IMO) the Table and Tree APIs are better to work with when the naming conventions reflect what you are building. The Table and Tree uses of Span could also deviate in the future and it felt prudent to leave room for future changes that may be specific to only one or the other.Otherwise a bit of tidying to get ready for TreeView!
Part of flutter/flutter#42332
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.