[in_app_purchase] Add api to expose country code #6540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: in_app_purchase
platform-android
platform-ios
platform-macos
labels
LouiseHsu
approved these changes
Apr 15, 2024
Contributor
LouiseHsu
left a comment
LouiseHsu
left a comment
There was a problem hiding this comment.
ios side lgtm! thanks for adding the ios implementation too!
gmackall
approved these changes
Apr 16, 2024
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
Android LGTM! Just some nitpicky docs comments
packages/in_app_purchase/in_app_purchase/lib/in_app_purchase.dart
Outdated
Show resolved
Hide resolved
packages/in_app_purchase/in_app_purchase_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
...ges/in_app_purchase/in_app_purchase_platform_interface/lib/src/in_app_purchase_platform.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Gray Mackall <[email protected]>
…ANGELOG.md Co-authored-by: Gray Mackall <[email protected]>
…b/src/in_app_purchase_platform.dart Co-authored-by: Gray Mackall <[email protected]>
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Minor comments, but this looks good to split out the first PR (with just the platform interface part).
| /// | ||
| /// | ||
| Future<void> countryCode() => | ||
| throw UnimplementedError('countryCode() has not been implemented.'); |
Collaborator
There was a problem hiding this comment.
Shouldn't this be calling the new platform interface method?
Collaborator
There was a problem hiding this comment.
And you'll want to add Dart unit tests at this layer that it is in fact calling through.
Contributor
Author
There was a problem hiding this comment.
Done! Thanks for the out of band explanation of this packages value.
| version: 3.2.0 | ||
|
|
||
| environment: | ||
| sdk: ^3.1.0 |
Collaborator
There was a problem hiding this comment.
FYI these values will need to be updated to match i_a_p_storekit's lower limits when you do the final app-facing PR, otherwise pub get will fail.
packages/in_app_purchase/in_app_purchase_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
...ges/in_app_purchase/in_app_purchase_platform_interface/lib/src/in_app_purchase_platform.dart
Show resolved
Hide resolved
… have a test in addition to in_app_purchase_interface
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
Original pr #6540 Related to flutter/flutter#141627
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
…kit (#6556) Part of flutter/flutter/issues/141627 reviewed pr #6540
Contributor
Author
|
Assuming the tests pass this pr is ready to land. |
reidbaker
added
the
override: no versioning needed
This comment was marked as outdated.
This comment was marked as outdated.
stuartmorgan-g
approved these changes
Apr 17, 2024
reidbaker
removed
the
override: no versioning needed
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2024
flutter/packages@d39830e...0e3809d 2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562) 2024-04-18 [email protected] [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551) 2024-04-17 [email protected] [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550) 2024-04-17 [email protected] [in_app_purchase] Add api to expose country code (flutter/packages#6540) 2024-04-17 [email protected] [camera] Initial iOS Pigeon conversion (flutter/packages#6553) 2024-04-17 [email protected] [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556) 2024-04-17 [email protected] [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404) 2024-04-17 [email protected] [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548) 2024-04-17 [email protected] [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@d39830e...0e3809d 2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562) 2024-04-18 [email protected] [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551) 2024-04-17 [email protected] [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550) 2024-04-17 [email protected] [in_app_purchase] Add api to expose country code (flutter/packages#6540) 2024-04-17 [email protected] [camera] Initial iOS Pigeon conversion (flutter/packages#6553) 2024-04-17 [email protected] [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556) 2024-04-17 [email protected] [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404) 2024-04-17 [email protected] [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548) 2024-04-17 [email protected] [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
- **Add changelog and version bump** - **dependency override from package tool** Fixes flutter/flutter/issues/141627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter/issues/141627
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).