Skip to content

[in_app_purchase_android] Cleanup, create listener where it is used #6489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Apr 10, 2024
Merged

[in_app_purchase_android] Cleanup, create listener where it is used #6489

auto-submit merged 8 commits into from
Apr 10, 2024

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Apr 8, 2024 •
edited
Loading

Fixes 144851

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker reidbaker changed the title y [in_app_purchase_android] Cleanup, create listener where it is used Apr 8, 2024
@reidbaker reidbaker marked this pull request as ready for review April 9, 2024 15:06
@reidbaker reidbaker requested a review from gmackall as a code owner April 9, 2024 15:06
@reidbaker reidbaker requested a review from stuartmorgan-g April 9, 2024 15:06
stuartmorgan-g
stuartmorgan-g approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one optional comment on versioning.

packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.3.4
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually a minor internal refactor would just be a bugfix version, which for <1.0 is +N by Dart convention, so I would make this 0.3.3+1. (I did an effectively minor version bump for the Pigeon changes since they made significant changes; even that was borderline IMO.)

Copy link
Contributor Author

@reidbaker reidbaker Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed,

gmackall
gmackall approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 10, 2024
@auto-submit auto-submit bot merged commit 2c15d86 into flutter:main Apr 10, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 10, 2024
@engine-flutter-autoroll
2c15d86 [in_app_purchase_android] Cleanup, create listener where it i…
7690bd8 
…s used (flutter/packages#6489)
@reidbaker reidbaker deleted the i144851-create-listener-in-correct-location branch April 10, 2024 15:20
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 10, 2024
@engine-flutter-autoroll
Roll Packages from 17f55d3 to 2c15d86 (2 revisions) (#146575)
82545f3 
flutter/packages@17f55d3...2c15d86

2024-04-10 [email protected] [in_app_purchase_android] Cleanup, create listener where it is used (flutter/packages#6489)
2024-04-09 [email protected] Roll Flutter from 533d04d to 4967a94 (12 revisions) (flutter/packages#6492)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@engine-flutter-autoroll @gilnobrega
Roll Packages from 17f55d3 to 2c15d86 (2 revisions) (flutter#146575)
cd72cc5 
flutter/packages@17f55d3...2c15d86

2024-04-10 [email protected] [in_app_purchase_android] Cleanup, create listener where it is used (flutter/packages#6489)
2024-04-09 [email protected] Roll Flutter from 533d04d to 4967a94 (12 revisions) (flutter/packages#6492)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@reidbaker @TecHaxter
[in_app_purchase_android] Cleanup, create listener where it is used (f…
4540dd1 
…lutter#6489)

Fixes [144851](flutter/flutter#144851)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@gmackall gmackall gmackall approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[in_app_purchase_android] Refactor listener to be created in implementation.

3 participants

@reidbaker @stuartmorgan-g @gmackall