Access current location using uri.path to support deep links #6474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
reviewed
Apr 8, 2024
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
Good call. This change looks good to me, can you also bump package version and change log?
Contributor
|
Some of the tests are failing. can you fix them as well? |
AhmedLSayed9
force-pushed
the
update_location_access
branch
from
db04931 to
05dfb08
Compare
Contributor
Author
When passing a query parameter, i.e doing:
So, accessing current location using If that's fine, I can fix the tests by checking for |
Contributor
Author
|
@chunhtai |
Contributor
|
I think you can just change the expect to ignore query parameter since now the example does not print query parameter onto the page.
I am fine with it |
AhmedLSayed9
force-pushed
the
update_location_access
branch
from
adfb7ae to
ab6f793
Compare
Contributor
Author
|
@chunhtai Can you check now? |
Contributor
|
looks like there are still some ci error |
Contributor
Author
|
@chunhtai |
hannah-hyj
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 12, 2024
flutter/packages@e98839a...78f684c 2024-04-12 [email protected] Roll Flutter from 557fbf5 to 53cba24 (11 revisions) (flutter/packages#6509) 2024-04-11 [email protected] [file_selector] Remove OCMock from iOS implementation (flutter/packages#6503) 2024-04-11 [email protected] Access current location using uri.path to support deep links (flutter/packages#6474) 2024-04-11 [email protected] Roll Flutter from 97cd47a to 557fbf5 (22 revisions) (flutter/packages#6502) 2024-04-11 [email protected] [packages] Set parallelizable to NO to reduce test flakiness in packages project tests (flutter/packages#6471) 2024-04-11 [email protected] Update multiple packages to depend on versions with iOS privacy manifest included (flutter/packages#6355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@e98839a...78f684c 2024-04-12 [email protected] Roll Flutter from 557fbf5 to 53cba24 (11 revisions) (flutter/packages#6509) 2024-04-11 [email protected] [file_selector] Remove OCMock from iOS implementation (flutter/packages#6503) 2024-04-11 [email protected] Access current location using uri.path to support deep links (flutter/packages#6474) 2024-04-11 [email protected] Roll Flutter from 97cd47a to 557fbf5 (22 revisions) (flutter/packages#6502) 2024-04-11 [email protected] [packages] Set parallelizable to NO to reduce test flakiness in packages project tests (flutter/packages#6471) 2024-04-11 [email protected] Update multiple packages to depend on versions with iOS privacy manifest included (flutter/packages#6355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…#6474) This PR updates examples to use `uri.path` instead of `uri.toString()` for accessing the current location. While the examples don't use deep linking, promoting the usage of `uri.toString()` in the examples doesn't seem to be a good idea as it can lead to issues when it's used with deep links (It'll include host and scheme).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates examples to use
uri.pathinstead ofuri.toString()for accessing the current location.While the examples don't use deep linking, promoting the usage of
uri.toString()in the examples doesn't seem to be a good idea as it can lead to issues when it's used with deep links (It'll include host and scheme).Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).