[two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells #6283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unpinned merged cells.
Piinks
added
the
p: two_dimensional_scrollables
11 tasks
goderbauer
approved these changes
Mar 7, 2024
| /// cellBuilder: (BuildContext context, TableVicinity vicinity) { | ||
| /// return Center( | ||
| /// child: Text('Cell ${vicinity.column} : ${vicinity.row}'), | ||
| /// return TableViewCell( |
Member
There was a problem hiding this comment.
There isn't a way to analyze snippets in this repo, right?
Contributor
Author
There was a problem hiding this comment.
Not that I am aware of. I searched the repo for cases of this but did not find any.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 8, 2024
…inned merged TableViewCells (flutter/packages#6283)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 8, 2024
flutter/packages@6701c9e...0badb43 2024-03-07 [email protected] [two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells (flutter/packages#6283) 2024-03-07 [email protected] Roll Flutter from 8f84f3f to 471a828 (27 revisions) (flutter/packages#6281) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#144100
Picks up doc fix from #6154 as well
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.