[in_app_purchase] fix skerror nullability #6139
Conversation
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Nice, I think this should chase down that issue.
You need to include the name of the package in the PR name.
| @@ -1,3 +1,7 @@ | |||
| ## 0.3.10+1 | |||
There was a problem hiding this comment.
This should be 0.3.11. The +N is reserved for changes that don't change the behavior.
| repository: https://github.com/flutter/packages/tree/main/packages/in_app_purchase/in_app_purchase_storekit | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22 | ||
| version: 0.3.10 | ||
| version: 0.3.10+1 |
LouiseHsu
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
LGTM! It's still mysterious how this bug happened. It may have to do with saved receipts? This should eliminate the possibility of it happening.
LouiseHsu
added
the
autosubmit
flutter/packages@ef349be...c56c12d 2024-02-16 [email protected] [tool] Add support for using a Kotlin test runner file (flutter/packages#6131) 2024-02-16 [email protected] [in_app_purchase] fix skerror nullability (flutter/packages#6139) 2024-02-15 [email protected] Explicitly pass the web renderer into the tests. (flutter/packages#6140) 2024-02-15 [email protected] [google_sign_in] Clean up pre-Pigeon code (flutter/packages#6141) 2024-02-15 [email protected] [local_auth] Add compatibility with latest `intl` (flutter/packages#6138) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Should fix flutter/flutter#143177
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).