[url_launcher] Replace deprecated RouteInformation APIs #6127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for https://docs.flutter.dev/release/breaking-changes/route-information-uri and makes 3.13 the minimum supported version accordingly. Fixes flutter/flutter#124045
Collaborator
Author
|
This should be a no-op functionally, since the first non-assert code in the called method is |
stuartmorgan-g
force-pushed
the
url-launcher-p-i-deprecation-cleanup
branch
from
d68a11b to
aa41fd2
Compare
ditman
approved these changes
Feb 15, 2024
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this!!
(How did this surface? did we add some new lints, or did that SystemNavigatorApi get deprecated recently?)
Collaborator
Author
|
It was surfaced at deprecation time by the Now that we no longer have that lint, there's a manual process for tracking deprecations instead (at least for now; TBD if Flutter-wide tooling will be built), and so I'm doing a quick sprint to clean up the ones I can easily fix now to reduce the scope of the manual tracking. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 15, 2024
flutter/packages@a864254...ef349be 2024-02-15 [email protected] [url_launcher] Replace deprecated RouteInformation APIs (flutter/packages#6127) 2024-02-15 [email protected] [rfw] Replace deprecated `textScaleFactor` (flutter/packages#6130) 2024-02-15 [email protected] [flutter_adaptive_scaffold] Replace deprecated APIs (flutter/packages#6129) 2024-02-14 [email protected] Roll Flutter from eb5d0a4 to a628814 (72 revisions) (flutter/packages#6118) 2024-02-14 [email protected] [flutter_migrate] Replace deprecated APIs (flutter/packages#6128) 2024-02-14 [email protected] [flutter_image] Replace deprecated APIs (flutter/packages#6126) 2024-02-14 [email protected] [tools] Ignore analysis options files in .symlinks (flutter/packages#6119) 2024-02-14 [email protected] [various] Clean up `deprecated_member_use` ignores (flutter/packages#6123) 2024-02-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.0 to 3.24.1 (flutter/packages#6121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for
https://docs.flutter.dev/release/breaking-changes/route-information-uri and makes 3.13 the minimum supported version accordingly.
Fixes flutter/flutter#124045
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).