[tools] Ignore analysis options files in .symlinks #6119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `analyze` in a local tree that has done builds, there can be false positives of the "unexpected analysis options" check due to the .symlinks directory making other packages' analysis options show up in the check. This avoids following links to prevent those false positives.
tarrinneal
approved these changes
Feb 13, 2024
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
Thank you for fixing this! Can all tooling ignore sylink files?
Collaborator
Author
|
Probably most of it? I should audit all the calls. |
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/6119, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 15, 2024
flutter/packages@a864254...ef349be 2024-02-15 [email protected] [url_launcher] Replace deprecated RouteInformation APIs (flutter/packages#6127) 2024-02-15 [email protected] [rfw] Replace deprecated `textScaleFactor` (flutter/packages#6130) 2024-02-15 [email protected] [flutter_adaptive_scaffold] Replace deprecated APIs (flutter/packages#6129) 2024-02-14 [email protected] Roll Flutter from eb5d0a4 to a628814 (72 revisions) (flutter/packages#6118) 2024-02-14 [email protected] [flutter_migrate] Replace deprecated APIs (flutter/packages#6128) 2024-02-14 [email protected] [flutter_image] Replace deprecated APIs (flutter/packages#6126) 2024-02-14 [email protected] [tools] Ignore analysis options files in .symlinks (flutter/packages#6119) 2024-02-14 [email protected] [various] Clean up `deprecated_member_use` ignores (flutter/packages#6123) 2024-02-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.0 to 3.24.1 (flutter/packages#6121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
analyzein a local tree that has done builds, there can be false positives of the "unexpected analysis options" check due to the .symlinks directory making other packages' analysis options show up in the check. This avoids following links to prevent those false positives.