[video_player] Call super.dispose last in README example
#6051
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
Good catch on this! Our README code samples are pulled directly from code snippets in the example app and must match what is in the app to pass the repo_checks tests.
you can just manually change the snippet to match, or change the snippet and run the code I linked to.
You'll also need to update the changlelog and versioning for this package or the changes you added wont be synced to the published package.
|
From triage: @tp, are you still planning on updating this PR to address the review comments above? |
Yes, I plan to update my PR with the proper way to fix this. In order to not cause further issues for the maintainers here managing this open PR I'll address this within 24 hours :) |
tp
force-pushed
the
patch-1
branch
3 times, most recently
from
80fa456 to
4e4fb62
Compare
|
@tarrinneal Thanks for the detailed explanation. I have updated the PR accordingly, and now only one job that fails across multiple open PRs (and seemingly unrelated) fails. |
Yep, tree-status isn't one you need to worry about. I'll add this back into my queue! Thanks for fixing it up! |
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
thanks for putting the time into this!
|
@stuartmorgan for second review |
stuartmorgan-g
added
the
autosubmit
|
auto label is removed for flutter/packages/6051, due to Pull request flutter/packages/6051 is not in a mergeable state. |
auto-submit
bot
removed
the
autosubmit
|
@tp any chance you can manage the version update conflict so we can land this? |
|
@tarrinneal No problem, quickly rebased this PR. |
|
Your rebase removed the version bump; PRs can't add changes to versions that have already been published. |
As per https://api.flutter.dev/flutter/widgets/State/dispose.html > Implementations of this method should end with a call to the inherited method, as in super.dispose().
🙈 Missed that the diff for the version bump in the Updated the version now. |
stuartmorgan-g
added
the
autosubmit
flutter/packages@dce6f0c...764d997 2024-04-05 [email protected] [video_player] Call `super.dispose` last in README example (flutter/packages#6051) 2024-04-04 [email protected] Fix macos_platform_tests package build times out when built for all packages (flutter/packages#6463) 2024-04-04 [email protected] Redistribute CODEOWNERS (flutter/packages#6457) 2024-04-04 [email protected] Roll Flutter from e868e2b to ac2ca93 (25 revisions) (flutter/packages#6460) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@dce6f0c...764d997 2024-04-05 [email protected] [video_player] Call `super.dispose` last in README example (flutter/packages#6051) 2024-04-04 [email protected] Fix macos_platform_tests package build times out when built for all packages (flutter/packages#6463) 2024-04-04 [email protected] Redistribute CODEOWNERS (flutter/packages#6457) 2024-04-04 [email protected] Roll Flutter from e868e2b to ac2ca93 (25 revisions) (flutter/packages#6460) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) As per https://api.flutter.dev/flutter/widgets/State/dispose.html > Implementations of this method should end with a call to the inherited method, as in super.dispose().
3 participants
As per https://api.flutter.dev/flutter/widgets/State/dispose.html