Skip the wasm test for now, it doesn't even actually test wasm currently #6044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyebrowsoffire
added
the
override: no versioning needed
github-actions
bot
added
p: web_benchmarks
and removed
override: no versioning needed
Contributor
Author
|
No versioning needed, we're just skipping a test and not changing any non-test code in the package itself. |
eyebrowsoffire
added
override: no versioning needed
yjbanov
approved these changes
Feb 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 5, 2024
flutter/packages@d37fb0a...ae3494d 2024-02-05 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.2 to 3.24.0 (flutter/packages#6050) 2024-02-03 [email protected] Skip the wasm test for now, it doesn't even actually test wasm currently (flutter/packages#6044) 2024-02-02 [email protected] [camerax] Clarify how CameraX uses preset resolution (flutter/packages#6022) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics for the wasm stuff is changing, and this is blocking the roll. See flutter/flutter#142809
Also, this test wasn't actually testing the wasm build previously, since it is still serving the
build/webdirectory even though--wasmused to actually output tobuild/web_wasm.