Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

  • Remove an iOS-only integration test from the app-facing package; there's already a copy in the iOS implementation package, and it's not relevant to the app-facing API.
  • Remove dead iOS native test code; the actual iOS native tests are all in the iOS package now, and this code isn't being run (since the repo tooling doesn't try to run native tests for plugins that don't have inline native implementations)

Fixes flutter/flutter#91004

Pre-launch Checklist

@stuartmorgan-g stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Feb 1, 2024
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 9, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 9, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 9, 2024

auto label is removed for flutter/packages/6031, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 9, 2024
@auto-submit auto-submit bot merged commit fe7d52d into flutter:main Feb 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 12, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 12, 2024
flutter/packages@11152d2...0a69259

2024-02-09 [email protected] [local_auth]: Renamed `local_auth_ios` to `local_auth_darwin` (flutter/packages#5809)
2024-02-09 [email protected] [webview_flutter] Add listener for content offset (flutter/packages#3444)
2024-02-09 [email protected] [go_router] Expose full `Uri` on `GoRouterState` in `GoRouterRedirect` (flutter/packages#5742)
2024-02-09 [email protected] [webview_flutter] Minor test cleanup (flutter/packages#6031)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: webview_flutter platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit webview_flutter tests

2 participants