[camerax] Change buildPreview to return Texture versus FutureBuilder
#6021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
approved these changes
Jan 31, 2024
| @@ -1,3 +1,8 @@ | |||
| ## 0.5.0+29 | |||
|
|
|||
| * Modifies `buildPreview` to return `Texture` that maps to camera preview, building in the assumption | |||
Contributor
There was a problem hiding this comment.
Consider linking to the issue that is being fixed.
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
…utureBuilder` (flutter/packages#6021)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
…utureBuilder` (flutter/packages#6021)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2024
flutter/packages@5b48c44...d37fb0a 2024-02-02 [email protected] Add a link the different possible Android virtual device configs (flutter/packages#6033) 2024-02-01 [email protected] Update the emulator versions and expose cipd. (flutter/packages#6025) 2024-02-01 [email protected] [tool] Add details to missing gradle coverage error (flutter/packages#6029) 2024-02-01 [email protected] [file_selector] Fix comment typo (flutter/packages#6027) 2024-02-01 [email protected] [camerax] Change `buildPreview` to return `Texture` versus `FutureBuilder` (flutter/packages#6021) 2024-02-01 [email protected] Manual roll Flutter from c65ab4d to e02e207 (38 revisions) (flutter/packages#6028) 2024-02-01 [email protected] Manual roll Flutter from 75a2e5b to c65ab4d (22 revisions) (flutter/packages#6026) 2024-02-01 [email protected] Roll Flutter from ace9181 to 75a2e5b (16 revisions) (flutter/packages#6017) 2024-02-01 [email protected] [webview_flutter] Support for handling basic authentication requests (flutter/packages#5727) 2024-01-31 [email protected] [tool] Extend `flutter test` workaround to other desktops (flutter/packages#6024) 2024-01-31 [email protected] [two_dimensional_scrollables] Merged cells for TableView (flutter/packages#5917) 2024-01-31 [email protected] [rfw] Restore RFW to 100% coverage after `ButtonBar` update (flutter/packages#6020) 2024-01-31 [email protected] [in_app_purchase] Convert storefront(), transactions(), canMakePayment(), and addPayment() to pigeon (flutter/packages#5910) 2024-01-31 [email protected] [in_app_purchase] Add play country code api (flutter/packages#5941) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
buildPreviewimplementation to return aTextureversus aFutureBuilderthat would ultimately return that sameTexture.The
FutureBuilderdepended on checking a condition that should be true by default assumingcreateCamerawas called prior. This seems to be an assumption made consistently across other platform implementations (includingcamera_android-- see source), so this PR is achieving consistency with them.Fixes flutter/flutter#140567. Thanks to @davidmartos96 for the push to investigate deeper on that issue!
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).