Add Kotlin to CONTRIBUTING.md #5970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include a mention of our Kotlin style and formatter.
tarrinneal
approved these changes
Jan 26, 2024
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
How am I supposed to review this much code?
stuartmorgan-g
added
the
autosubmit
Contributor
|
tree is actually green, so submitting |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 29, 2024
flutter/packages@cbe8100...516648a 2024-01-28 [email protected] [go_router] Add `topRoute` to `GoRouterState` (flutter/packages#5736) 2024-01-27 [email protected] Add Kotlin to CONTRIBUTING.md (flutter/packages#5970) 2024-01-26 [email protected] Roll Flutter (stable) from 67457e6 to 4145645 (1 revision) (flutter/packages#5979) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never updated the contributing notes about languages when we added Kotlin to the repo.