[webview_flutter] Use a local web server for legacy web integration tests #5956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
changed the title
ditman
approved these changes
Jan 23, 2024
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
This should be much more stable! (Small question on using the loopback instead of "any" when binding the server)
| const String secondaryUrl = 'https://www.google.com/robots.txt'; | ||
| const String primaryPage = 'first.txt'; | ||
| const String secondaryPage = 'second.txt'; | ||
| final HttpServer server = await HttpServer.bind(InternetAddress.anyIPv4, 0); |
Member
There was a problem hiding this comment.
Can this be:
Suggested change
| final HttpServer server = await HttpServer.bind(InternetAddress.anyIPv4, 0); | |
| final HttpServer server = await HttpServer.bind(InternetAddress.loopbackIPv4, 0); |
So you can connect only from http://localhost:${server.port}?
Collaborator
Author
There was a problem hiding this comment.
Seems to work; done. The previous version was just copying from other tests (I think Ian wrote the first one.)
Member
There was a problem hiding this comment.
I think the other version just opens a random port on the machine that could potentially be connected to from the outside world? (I don't know the security ramifications, but if I do that internally at work I get an automated email flagging it :P)
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 24, 2024
flutter/packages@841fe90...8fbdf65 2024-01-23 [email protected] [webview_flutter] Use a local web server for legacy web integration tests (flutter/packages#5956) 2024-01-23 [email protected] Roll Flutter from 3ee8ff2 to 5b673c2 (28 revisions) (flutter/packages#5965) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a local web server for the legacy test, just as for the non-legacy version.
Also updates the repo tooling to ensure that this test file is found, so it's run regardless of whether tests are run by directory or by individual path.
Part of flutter/flutter#95420
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).