[url_launcher]: Fix a grammar error in the comments of launchUrl method #5919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The CLA link isn't opening for me. Will check back in a few hours to see if it starts working again. |
stuartmorgan-g
requested changes
Jan 19, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This will need a version change:
- I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
Collaborator
|
I missed that this is missing an actual version change in the pubspec.yaml (or it was there, and was lost in a merge); it will need that in order to land. |
Contributor
Author
|
Oops, of course. Sorry for missing that. Will do it right now |
Contributor
Author
|
Done! |
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2024
flutter/packages@e4cbf23...841fe90 2024-01-22 [email protected] [two_dimensional_scrollables] Fix TableSpanDecoration rects when axes are reversed (flutter/packages#5916) 2024-01-22 [email protected] [most on Android] Bump compile SDK version to 34 (flutter/packages#5783) 2024-01-22 [email protected] [url_launcher]: Fix a grammar error in the comments of launchUrl method (flutter/packages#5919) 2024-01-22 [email protected] [webview_platform_interface] Adds WebResourceRequest to HttpResponseError (flutter/packages#5790) 2024-01-22 [email protected] [camerax] Update `Activity` references when `ActivityAware` lifecycle methods called (flutter/packages#5784) 2024-01-22 [email protected] Roll Flutter from 5dea6b9 to 3ee8ff2 (9 revisions) (flutter/packages#5955) 2024-01-22 [email protected] [espresso] Replace deprecated `getObservatoryUri` (flutter/packages#5788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a grammer error in the comments of
launchUrl()method. This PR fixes the error.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.