Skip to content

[various] Update minimum iOS versions to 12.0 #5902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 13 commits into from
Jan 17, 2024
Merged

[various] Update minimum iOS versions to 12.0 #5902

auto-submit merged 13 commits into from
Jan 17, 2024

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Jan 16, 2024 •
edited
Loading

This makes the following mass changes:

  • Builds all examples with current stable (3.16.7), to pick up the auto-migration of projects to a minimum of iOS 12.
    • In some cases this picks up other boilerplate Xcode project migrations that had never been checked in to those projects.
  • Updates all iOS plugin implementations to indicate that they require iOS 12.0 or later.
  • Updates all the READMEs of the app-facing versions of those plugins to indicate that iOS 11 will no longer receive implementation updates.

The only code changes are:

  • the removal of some @available checks in in_app_purchase_storekit that had become no-ops with the support change
  • the removal of a ! in camera_avfoundation Dart code, which is no longer necessary due to changes in nullable field promotion in newer versions of Dart.

These changes are version-exempt per repo policy, so the changelog changes all use NEXT.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g added the override: no versioning needed Override the check requiring version bumps for most changes label Jan 16, 2024
@stuartmorgan-g stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jan 16, 2024
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jan 16, 2024

Changelog override: the packages missing changelog changes just have uninteresting example project changes.

jmagman
jmagman approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM, thanks for doing it.

packages/google_maps_flutter/google_maps_flutter/example/ios/Runner.xcodeproj/project.pbxproj
inputPaths = (
"${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-resources.sh",
"${PODS_ROOT}/GoogleMaps/Maps/Frameworks/GoogleMaps.framework/Resources/GoogleMaps.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/google_maps_flutter_ios/google_maps_flutter_ios_privacy.bundle",
Copy link
Member

@jmagman jmagman Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize adding the privacy bundle would update the host Xcode project, not just the generated Pod project.

Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the non-use_frameworks version.

It's not really clear what the "right" behavior for privacy manifests with non-framework pods even is (not just in Flutter, but in general). Are app developers supposed to be responsible for copying any privacy details into their own manifest manually? Should Cocoapods in theory have magic tooling to merge them in the app's manifest automatically?

I'm assuming in the long term the answer is to use SPM, and the new static frameworks system, at which point presumably Xcode magic will handle it. But for now, having them end up in a weird bundle is kind of the only option that people have found for shimming this into Cocoapods (if you don't use a bundle, it instead stomps the main privacy manifest, which is obviously worse). We'll see what happens with this when the validation tooling goes live 🤷🏻

@stuartmorgan-g stuartmorgan-g mentioned this pull request Jan 16, 2024
Closed
Piinks
Piinks approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2024
@auto-submit auto-submit bot merged commit 4c5375d into flutter:main Jan 17, 2024
@stuartmorgan-g stuartmorgan-g deleted the ios-12-min branch January 17, 2024 03:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 17, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2024
@engine-flutter-autoroll
4c5375d [various] Update minimum iOS versions to 12.0 (flutter/packag…
1a97379 
…es#5902)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 17, 2024
@engine-flutter-autoroll
Roll Packages from 7dd0fcb to 1a2b780 (6 revisions) (#141683)
a10712e 
flutter/packages@7dd0fcb...1a2b780

2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Run check_podspecs on arm Mac bots" (flutter/packages#5909)
2024-01-17 [email protected] [various] Update minimum iOS versions to 12.0 (flutter/packages#5902)
2024-01-16 [email protected] [ci] Run check_podspecs on arm Mac bots (flutter/packages#5885)
2024-01-16 [email protected] [pigeon] Fix pigeon test generation missing wrapResponse method. (flutter/packages#5903)
2024-01-16 [email protected] Roll Flutter from 1a2c315 to 8e94423 (2 revisions) (flutter/packages#5897)
2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/packages#5896)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@jmagman jmagman mentioned this pull request Feb 8, 2024
Closed
8 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@jmagman jmagman jmagman approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

@Piinks Piinks Piinks approved these changes

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu LouiseHsu is a code owner

@vashworth vashworth Awaiting requested review from vashworth vashworth is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@chunhtai chunhtai Awaiting requested review from chunhtai chunhtai is a code owner

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: animations p: camera p: dynamic_layouts The dynamic_layouts package p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_adaptive_scaffold p: flutter_image p: flutter_markdown p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: ios_platform_images p: local_auth p: palette_generator p: path_provider p: pigeon p: pointer_interceptor p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stuartmorgan-g @domesticmouse @jmagman @gspencergoog @Piinks