Add transitionDuration parameter #5854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `transitionDuration` parameter for specifying how long the animation should be.
- Test if animation ends at declared duration.
fix incorrect versioning
# Conflicts: # packages/flutter_adaptive_scaffold/CHANGELOG.md # packages/flutter_adaptive_scaffold/pubspec.yaml
# Conflicts: # packages/flutter_adaptive_scaffold/CHANGELOG.md # packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart # packages/flutter_adaptive_scaffold/pubspec.yaml
Contributor
Author
|
This was previously opened but closed due to CI failure and no edits after draft, so I opened it again. |
Contributor
Author
|
@stuartmorgan please check macOS RunnerTest. Thanks. |
Remove unnecessary deps
packages/flutter_adaptive_scaffold/example/lib/adaptive_layout_demo.dart
Outdated
Show resolved
Hide resolved
packages/flutter_adaptive_scaffold/example/lib/adaptive_scaffold_demo.dart
Outdated
Show resolved
Hide resolved
packages/flutter_adaptive_scaffold/example/lib/adaptive_layout_demo.dart
Outdated
Show resolved
Hide resolved
packages/flutter_adaptive_scaffold/example/lib/adaptive_scaffold_demo.dart
Outdated
Show resolved
Hide resolved
packages/flutter_adaptive_scaffold/example/test/adaptive_scaffold_demo_test.dart
Outdated
Show resolved
Hide resolved
stuartmorgan-g
approved these changes
Feb 7, 2024
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 8, 2024
flutter/packages@e4ea6bf...29d8cc0 2024-02-07 [email protected] [local_auth] fix: isDeviceSupported on ios (flutter/packages#5125) 2024-02-07 [email protected] [image_picker] Suppress analyzer warning about deprecation of UnmodifiableUint8ListView (flutter/packages#6076) 2024-02-07 [email protected] Add transitionDuration parameter (flutter/packages#5854) 2024-02-07 [email protected] Roll Flutter from e6ba809 to 8431cae (23 revisions) (flutter/packages#6075) 2024-02-07 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Adds support for `setOnScrollPositionChange` for webview_flutter platform implementations (flutter/packages#5664) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds transitionDuration parameter for specifying how long the animation should be.
This adds the following suggestion from the issue flutter/flutter#114272
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.