[url_launcher] Add InAppBrowserConfiguration parameter in implementations
#5759
Conversation
|
This is #5166 but only with android implementation changes |
|
Marking as a draft for now; the sub-PRs can't proceed without the dependencies landing first. The overall pre-review is done in the main PR. |
|
@stuartmorgan sorry for tagging. could you please review this PR? it seems to have slipped through the cracks. thanks! |
You only marked it as ready for review at the end of last week; it often takes more than two working days for a PR to be reviewed. |
|
Sorry, did not mean to be pushy. I am just quite unaware of the process and assumed that once the child prs are going to be taken care of once the main one was approved (perhaps a silly assumption to make, you guys have a lot of responsibilities without this) Since this one was in drafts for a month, I thought this one got lost. Once again sorry for misunderstanding and disturbance! |
We follow the process described at https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
We don't generally look at draft PRs, we wait for the author of the PR to mark it as ready for review. |
packages/url_launcher/url_launcher_android/example/pubspec.yaml
Outdated
Show resolved
Hide resolved
packages/url_launcher/url_launcher_android/pigeons/messages.dart
Outdated
Show resolved
Hide resolved
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, @gmackall for secondary review.
stuartmorgan-g
added
the
autosubmit
flutter/packages@9385bbb...a864254 2024-02-14 [email protected] Allow deprecated members from the Dart SDK/Flutter Framework to roll in (flutter/packages#6111) 2024-02-14 [email protected] [google_maps_flutter][iOS 12] Skip `testTakeSnapshot` (flutter/packages#6120) 2024-02-13 [email protected] [ci] Allow dependencies on local_auth_ios (flutter/packages#6116) 2024-02-13 [email protected] [url_launcher] Add `InAppBrowserConfiguration` parameter in implementations (flutter/packages#5759) 2024-02-13 [email protected] [flutter_markdown] Use Text.rich to replace RichText in Flutter Markdown (flutter/packages#6062) 2024-02-13 [email protected] [google_maps_flutter][iOS 17] takeSnapshot FIX (flutter/packages#5823) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Platform implementation portion of #5166. Implements
InAppBrowserConfigurationsupport on Android, as well as support forInAppBrowserConfiguration.showTitleparameter for hiding/showing webpage title in Android Custom Tabs.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.