[url_launcher] Add InAppBrowserConfiguration parameter
#5758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is #5166 but only with platform interface changes |
stuartmorgan-g
approved these changes
Jan 3, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with nit
@gmackall for secondary review.
| ## NEXT | ||
| ## 2.3.0 | ||
|
|
||
| * Adds `InAppBrowserConfiguration` parameter to `LaunchOptions`, to configure in-app browser views, such as Android Custom Tabs or SFSafariViewController. |
Collaborator
There was a problem hiding this comment.
Nit: `SFSafariViewController`
gmackall
approved these changes
Jan 3, 2024
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
LGTM! Holding off on autosubmit to give time to address @stuartmorgan's nit
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 5, 2024
flutter/packages@31fc7b5...b9b6d38 2024-01-05 [email protected] Manual roll Flutter from 11def8e to cc40425 (118 revisions) (flutter/packages#5806) 2024-01-05 [email protected] [ci] Run 'flutter build --config-only for iOS and macOS during fetch deps (flutter/packages#5804) 2024-01-05 [email protected] [image_picker] Remove input element after completion (flutter/packages#5654) 2024-01-05 [email protected] [video_player] Fix initial frame on macOS (flutter/packages#5781) 2024-01-05 [email protected] [pigeon] java non null void (flutter/packages#5786) 2024-01-04 [email protected] [file_selector_android] Attempt to close system dialogs before integration tests run (flutter/packages#5805) 2024-01-04 [email protected] [tool] Handle Flutter dev dependencies (flutter/packages#5775) 2024-01-04 [email protected] [url_launcher] Add `InAppBrowserConfiguration` parameter (flutter/packages#5758) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
11 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #5166 portion of platform interface changes. Adds
InAppBrowserConfigurationparameter, as well asInAppBrowserConfiguration.showTitleparameter that configures whether to show or not to show webpage titlePre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.