Disable presubmit: false targets for recipes CQ
#5735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
approved these changes
Dec 21, 2023
keyonghan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 22, 2023
flutter/packages@4c3bc49...23d2d9c 2023-12-22 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.3.1 to 1.3.3 (flutter/packages#5737) 2023-12-21 [email protected] Disable `presubmit: false` targets for recipes CQ (flutter/packages#5735) 2023-12-21 [email protected] [go_router] Refactored RouteMatchList and imperative APIs (flutter/packages#5497) 2023-12-21 [email protected] Add env_variables in ci.yaml (flutter/packages#5730) 2023-12-21 [email protected] Roll Flutter (stable) from 2e9cb0a to 78666c8 (1 revision) (flutter/packages#5734) 2023-12-21 [email protected] Roll Flutter from da0cd69 to 11def8e (16 revisions) (flutter/packages#5732) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
flutter/packages@4c3bc49...23d2d9c 2023-12-22 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.3.1 to 1.3.3 (flutter/packages#5737) 2023-12-21 [email protected] Disable `presubmit: false` targets for recipes CQ (flutter/packages#5735) 2023-12-21 [email protected] [go_router] Refactored RouteMatchList and imperative APIs (flutter/packages#5497) 2023-12-21 [email protected] Add env_variables in ci.yaml (flutter/packages#5730) 2023-12-21 [email protected] Roll Flutter (stable) from 2e9cb0a to 78666c8 (1 revision) (flutter/packages#5734) 2023-12-21 [email protected] Roll Flutter from da0cd69 to 11def8e (16 revisions) (flutter/packages#5732) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Collaborator
|
So what would catch a recipe change that broke handling of non- |
Contributor
Author
|
There are still This PR disables only those that are not running in packages presubmit. |
Collaborator
|
Ah, yes, that's probably fine then. |
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These targets are not enabled in presubmit, but enabled in CQ. This caused latest changes not surfaced from CQ side: CQ runs are based on out dated try runs. For example:
Mac_arm64 ios_platform_tests_shard_1 stableis using the old build executed on 12/13: https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20ios_platform_tests_shard_1%20stableThis PR disables CQ for targets that are with
presubmit: false, to unblock recipes CL: https://flutter-review.googlesource.com/c/recipes/+/53301