[web_benchmarks] Add support for analyzing benchmark results #5630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
changed the title
elliette
approved these changes
Dec 8, 2023
yjbanov
reviewed
Dec 9, 2023
yjbanov
reviewed
Dec 11, 2023
yjbanov
reviewed
Dec 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 12, 2023
flutter/packages@cb6dbcd...80aa46a 2023-12-12 [email protected] Manual roll Flutter from c642f4e to 9719097 (25 revisions) (flutter/packages#5648) 2023-12-12 [email protected] [web_benchmarks] Add support for analyzing benchmark results (flutter/packages#5630) 2023-12-11 [email protected] [pointer_interceptor] Fully publish pointer_interceptor package (flutter/packages#5640) 2023-12-11 [email protected] Manually roll Flutter (stable) from db7ef5b to b0366e0 (8 revisions) (flutter/packages#5632) 2023-12-11 [email protected] Manually roll Flutter from f35d049 to c642f4e (92 revisions) (flutter/packages#5631) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new top level library
analysis.dartthat exposes methods:computeDeltacomputeAverageThese were already added to DevTools in flutter/devtools#6918 and flutter/devtools#6920, respectively, but I think it makes more sense to upstream this logic into
package:web_benchmarksso that other users of this package can take advantage of it.As part of this PR, I have updated the README to give an example of how to use the analysis features.