Skip to content

Conversation

@kenzieschmoll
Copy link
Member

No description provided.

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenzieschmoll kenzieschmoll added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2023
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@auto-submit auto-submit bot merged commit 935b92f into flutter:main Dec 8, 2023
@kenzieschmoll kenzieschmoll deleted the parse branch December 8, 2023 19:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 11, 2023
flutter/packages@6cd0657...cb6dbcd

2023-12-09 [email protected] [multicast_dns] Adjust README (flutter/packages#5529)
2023-12-09 [email protected] [tool] Use ^ for Dart SDK (flutter/packages#5623)
2023-12-09 [email protected] [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612)
2023-12-08 [email protected] [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629)
2023-12-08 [email protected] Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614)
2023-12-08 [email protected] [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619)
2023-12-08 [email protected] [ci] Fix indentation in labeler.yml (flutter/packages#5625)
2023-12-08 [email protected] Update labeler to 5.0.0, fix yml format (flutter/packages#5580)
2023-12-08 [email protected] [url_launcher] Adds documentation that a launch needs to be triggered  by a user action (flutter/packages#5143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: web_benchmarks waiting for tree to go green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants