Add the ability to run web_benchmarks with Wasm #5611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
reviewed
Dec 7, 2023
| required this.chromeDebugPort, | ||
| required this.headless, | ||
| required this.treeShakeIcons, | ||
| this.useWasm = false, |
Contributor
There was a problem hiding this comment.
I wonder if this will have the same effect as useCanvasKit above. useCanvasKit ended up being not extensible enough, so we'll need to make a breaking change to accommodate Skwasm. I wonder if we should instead have a CompilationOptions object that can be extended in the future. cc @eyebrowsoffire
Member
Author
There was a problem hiding this comment.
I added a CompilationOptions class. PTAL @yjbanov @eyebrowsoffire. Since this is a breaking change, I also did a major version bump - let me know if we want to hold off on bringing this package to '1.0.0'.
kevmoo
reviewed
Dec 7, 2023
| class CompilationOptions { | ||
| /// Creates a [CompilationOptions] object. | ||
| const CompilationOptions({ | ||
| this.renderer = WebRenderer.html, |
Contributor
There was a problem hiding this comment.
The default should ABSOLUTELY be canvaskit. I'd say ditch the html option entirely!
Contributor
There was a problem hiding this comment.
Well, this is published. Maybe just default to canvaskit
eyebrowsoffire
approved these changes
Dec 7, 2023
Contributor
eyebrowsoffire
left a comment
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Looks good to me!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 8, 2023
flutter/packages@15584a3...6cd0657 2023-12-08 [email protected] [gis_web] Correct pub.dev changelog entry. (flutter/packages#5613) 2023-12-08 [email protected] Add the ability to run web_benchmarks with Wasm (flutter/packages#5611) 2023-12-08 [email protected] [google_sign_in] Endorse macOS implementation (flutter/packages#5600) 2023-12-07 [email protected] [go_router_builder] add support to `go_router_builder` for initializing a `ShellRoute` with `observers` (flutter/packages#5563) 2023-12-07 [email protected] [go_router] Fix(docs): Typo in Update navigation.md (flutter/packages#5545) 2023-12-07 [email protected] [two_dimensional_scrollables] Expose addAutomaticKeepAlives in Table delegates (flutter/packages#5597) 2023-12-07 [email protected] [pigeon] Fix pigeon issue_tracker link (flutter/packages#5505) 2023-12-07 [email protected] Pointer interceptor implementations (flutter/packages#5594) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same run flags that the flutter benchmark tests use: https://github.com/flutter/flutter/blob/master/dev/devicelab/lib/tasks/web_benchmarks.dart#L36-L40
CC @kevmoo