Pointer interceptor implementations #5594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseHsu
commented
Dec 6, 2023
| version: 0.10.0 | ||
|
|
||
| environment: | ||
| sdk: '>=3.1.0 <4.0.0' |
Contributor
Author
There was a problem hiding this comment.
updated constraint here
LouiseHsu
commented
Dec 6, 2023
| version: 0.10.0 | ||
|
|
||
| environment: | ||
| sdk: '>=3.1.0 <4.0.0' |
Contributor
Author
There was a problem hiding this comment.
and updated constraint here
stuartmorgan-g
approved these changes
Dec 7, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Diffs LGTM
Sorry for the delay, I'm not sure how I missed the email for this until now.
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 8, 2023
flutter/packages@15584a3...6cd0657 2023-12-08 [email protected] [gis_web] Correct pub.dev changelog entry. (flutter/packages#5613) 2023-12-08 [email protected] Add the ability to run web_benchmarks with Wasm (flutter/packages#5611) 2023-12-08 [email protected] [google_sign_in] Endorse macOS implementation (flutter/packages#5600) 2023-12-07 [email protected] [go_router_builder] add support to `go_router_builder` for initializing a `ShellRoute` with `observers` (flutter/packages#5563) 2023-12-07 [email protected] [go_router] Fix(docs): Typo in Update navigation.md (flutter/packages#5545) 2023-12-07 [email protected] [two_dimensional_scrollables] Expose addAutomaticKeepAlives in Table delegates (flutter/packages#5597) 2023-12-07 [email protected] [pigeon] Fix pigeon issue_tracker link (flutter/packages#5505) 2023-12-07 [email protected] Pointer interceptor implementations (flutter/packages#5594) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
@LouiseHsu thanks for implementing the pointer interceptor. Currently we cannot use the pointer interceptor for SnackBars. Is there an extension planned for that? |
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the same PR as #5500, with pubspec updates
Addresses flutter/flutter#30143 by adding an iOS implementation
This PR is Part 2 of #5233
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).