[go_router_builder] add support to go_router_builder for initializing a ShellRoute with observers
#5563
Conversation
feat: add observers support to `ShellRouteData`
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
My intent is to add a test, but in order to do so I'll need to pull in |
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, please update the version bump
Co-authored-by: chunhtai <[email protected]>
hannah-hyj
added
the
autosubmit
…itializing a `ShellRoute` with `observers` (flutter/packages#5563)
flutter/packages@15584a3...6cd0657 2023-12-08 [email protected] [gis_web] Correct pub.dev changelog entry. (flutter/packages#5613) 2023-12-08 [email protected] Add the ability to run web_benchmarks with Wasm (flutter/packages#5611) 2023-12-08 [email protected] [google_sign_in] Endorse macOS implementation (flutter/packages#5600) 2023-12-07 [email protected] [go_router_builder] add support to `go_router_builder` for initializing a `ShellRoute` with `observers` (flutter/packages#5563) 2023-12-07 [email protected] [go_router] Fix(docs): Typo in Update navigation.md (flutter/packages#5545) 2023-12-07 [email protected] [two_dimensional_scrollables] Expose addAutomaticKeepAlives in Table delegates (flutter/packages#5597) 2023-12-07 [email protected] [pigeon] Fix pigeon issue_tracker link (flutter/packages#5505) 2023-12-07 [email protected] Pointer interceptor implementations (flutter/packages#5594) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
| if (parameterName.toLowerCase().contains('navigatorkey')) { | ||
| if (parameterName | ||
| .toLowerCase() | ||
| .contains(RegExp('navigatorKey | observers'))) { |
There was a problem hiding this comment.
Won't this no longer match against navigatorKey due to the toLowerCase() call? It also would require a space after navigatorKey or before observers in order to actually match
4 participants
This pr added the ability to provide a list of
NavigatorObserversto aShellRoute. The equivalent was never added togo_router_builder, so this pr provides that functionality.This is a workaround to this issue where navigator observers added to a
GoRouterat the top level do not fire inShellRoutes. With this change, you can provideNavigatorObserversdirectly to theShellRoutePre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.