Skip to content

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Dec 1, 2023

Now that the Windows build directory update migration is on the stable channel, add the build-only Windows Arm64 CI stable test.

Part of flutter/flutter#129813

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit.

timeout: 30
bringup: true
properties:
add_recipes_cq: "true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this; feedback from infra recently is that we should err on the side of only adding things to the recipes CQ if they are substantially different than existing things that are there from a recipe standpoint.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, updated!

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 4, 2023
@auto-submit auto-submit bot merged commit 4e7f160 into main Dec 4, 2023
@auto-submit auto-submit bot deleted the windows_arm64_stable_ci branch December 4, 2023 20:53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 5, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 5, 2023
flutter/packages@5d9874f...4e7f160

2023-12-04 [email protected] [ci] Add Windows Arm64 stable build-only test (flutter/packages#5533)
2023-12-04 [email protected] [various] Update mockito to 5.4.3 (flutter/packages#5530)
2023-12-04 [email protected] Add an optional parameter `initialPage` to `serveWebBenchmark` (flutter/packages#5538)
2023-12-04 [email protected] Roll Flutter from d861ce4 to f35d049 (7 revisions) (flutter/packages#5564)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants