-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[ci] Add Windows Arm64 stable build-only test #5533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit.
| timeout: 30 | ||
| bringup: true | ||
| properties: | ||
| add_recipes_cq: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this; feedback from infra recently is that we should err on the side of only adding things to the recipes CQ if they are substantially different than existing things that are there from a recipe standpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, updated!
flutter/packages@5d9874f...4e7f160 2023-12-04 [email protected] [ci] Add Windows Arm64 stable build-only test (flutter/packages#5533) 2023-12-04 [email protected] [various] Update mockito to 5.4.3 (flutter/packages#5530) 2023-12-04 [email protected] Add an optional parameter `initialPage` to `serveWebBenchmark` (flutter/packages#5538) 2023-12-04 [email protected] Roll Flutter from d861ce4 to f35d049 (7 revisions) (flutter/packages#5564) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Now that the Windows build directory update migration is on the stable channel, add the build-only Windows Arm64 CI stable test.
Part of flutter/flutter#129813
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.