[tool] Add Kotlin autoformatting #5374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested review from
Hixie,
Piinks,
chunhtai,
domesticmouse,
goderbauer,
gspencergoog and
tarrinneal
as code owners
github-actions
bot
added
p: palette_generator
p: pigeon
p: flutter_markdown
p: flutter_image
p: rfw
Collaborator
Author
|
@reidbaker I'll wait for your approval on this as the primary stakeholder who hasn't weighed in yet. Everyone else can ignore this; it touched a lot of examples which force-added a lot of reviewers :( |
stuartmorgan-g
added
the
override: no changelog needed
Collaborator
Author
|
Overriding changelog: The app boilerplate changes are uninteresting to package clients. |
stuartmorgan-g
added
the
override: no versioning needed
Collaborator
Author
|
Overriding version: There's minor formatting change to the Pigeon README which can go out in the next Pigeon release (we have several lined up, and skipping the versioning here avoids conflicts in those). |
reidbaker
approved these changes
Nov 13, 2023
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 14, 2023
flutter/packages@17bd92e...428ba3e 2023-11-13 [email protected] [pigeon] Remove semicolons from Kotlin generation (flutter/packages#5375) 2023-11-13 [email protected] [tool] Add Kotlin autoformatting (flutter/packages#5374) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the tooling to fetch and use
ktfmtfor Kotlin code, the same way it currently does for the Google Java formatter, and applies that formatting (in the default mode; see discussion in the linked issue) to the repository.In the future we could revisit the formatter or mode, but since this currently seems to be the most consistent with our other languages and to google3 formatting this is likely the option we'll want to stick with.
Fixes flutter/flutter#118756
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.