[video_player] Update example app to replace ButtonBar with OverflowBar
#5274
Conversation
…owBar` Bump version
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages/5274, due to - The status or check suite Linux_android android_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
@stuartmorgan why didn't this need a test exemption when it asked for one originally? |
|
Because I forgot to put the comment 🤦🏻 Thanks for flagging that! test-exempt: unblocks a future roll that will automatically test the change via analysis |
flutter/packages@c9fec61...6ad40b9 2023-11-01 [email protected] Roll Flutter from e12d1a7 to 29b2516 (34 revisions) (flutter/packages#5290) 2023-11-01 [email protected] [file_selector] Updates iOS to Pigeon 13 (flutter/packages#5268) 2023-10-31 [email protected] [camera_avfoundation] � Fix inverted orientation strings (flutter/packages#5261) 2023-10-31 [email protected] [tool] Add option for Android compile SDK version to update-dependencies command (flutter/packages#5010) 2023-10-31 [email protected] [video_player] Update iOS/macOS to Pigeon 13 (flutter/packages#5270) 2023-10-31 [email protected] [video_player] Update example app to replace `ButtonBar` with `OverflowBar` (flutter/packages#5274) 2023-10-31 [email protected] [image_picker] Update iOS to Pigeon 13 (flutter/packages#5266) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This PR replaces
ButtonBarwithOverflowBarinvideo_player/examplein preparation ofButtonBardeprecation.Related to flutter/flutter#127955
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.