[camera] Camera with MediaSettings: platform implementations (federated) #5223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaSettings.low changed to const MediaSettings(resolutionPreset: ResolutionPreset.low).
Co-authored-by: Camille Simon <[email protected]>
Co-authored-by: Maurice Parrish <[email protected]>
mossmana
changed the title
jmagman
approved these changes
Mar 13, 2024
Member
|
@stuartmorgan this is blocked on your review |
stuartmorgan-g
requested changes
Mar 14, 2024
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.h
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettingsAVWrapper.h
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettingsAVWrapper.h
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSettingsTests.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@stuartmorgan Thank, you for review. Your suggestions are applied. |
Contributor
|
@stuartmorgan Can you take a look when you have time? |
stuartmorgan-g
requested changes
Apr 4, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Sorry for the delay again; just a few last small things.
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.h
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@stuartmorgan suggestions applied |
stuartmorgan-g
approved these changes
Apr 5, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM! Could you rebase and squash a few of the commits together to get this under 250 commits, so that the CLA check will pass without intervention?
suggestions applied AssertPositiveNumberOrNil: macro to inline formatted .class to +class Update packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m Co-authored-by: Jenn Magder <[email protected]> applied suggestions. 02/25/2024. dependency injection (DI) variant for unit test ObjC suggestions applied suggestion applied updated camera_platform_interface versions reverted changes to camera merged 01/07/2024 refactored and co0mmented warning suppressions. renamed MediaRecorderBuilder.RecordingParameters merged 12/07/2023
PROGrand
force-pushed
the
camera-with-settings-platform-implementations
branch
from
faa7b8f to
adf6929
Compare
stuartmorgan-g
requested changes
Apr 5, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
A bunch of files showed as changed since review, and because of the squash I can't tell if that's a GitHub artifact of the squash, or actual changes, so I re-reviewed those files. That turned up a few more minor comments which may be things I just didn't previously review, but I've flagged them regardless. Sorry that means one more quick pass.
packages/camera/camera_avfoundation/example/lib/camera_controller.dart
Outdated
Show resolved
Hide resolved
two lines
Contributor
Author
|
@stuartmorgan resolved |
stuartmorgan-g
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform implementations of federated plugin
This is the
platform implementationspart ofcameraPR #3586.camera_platform_interface: 2.6.0merged and published in PR #3615.Now repeating steps 3,4 (see Changing federated plugins), because
camera/cameradepends on implementationscamera/camera_android,camera/camera_webetc.