Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Enables the new legacy emulator targets.

Fixes flutter/flutter#130010

Enables the new legacy emulator targets.

Fixes flutter/flutter#130010
@stuartmorgan-g
Copy link
Collaborator Author

Ugh, I got the capitalization wrong on the names. I'll do a prequel PR to rename them before we're more stuck with it.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft October 20, 2023 15:33
@reidbaker
Copy link
Contributor

Ugh, I got the capitalization wrong on the names. I'll do a prequel PR to rename them before we're more stuck with it.

What is the correct capitalization supposed to be

@stuartmorgan-g
Copy link
Collaborator Author

All the other tasks capitalize the OS name.

@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review October 24, 2023 20:10
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 24, 2023

auto label is removed for flutter/packages/5190, due to - The status or check suite Linux_android android_platform_tests_api_33_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2023
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 25, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 25, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 25, 2023

auto label is removed for flutter/packages/5190, due to - The status or check suite Linux_android android_platform_tests_api_33_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 25, 2023
@auto-submit auto-submit bot merged commit f751ffb into flutter:main Oct 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 25, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 25, 2023
flutter/packages@2faf992...f751ffb

2023-10-25 [email protected] [ci] Enable legacy Android emulator tests (flutter/packages#5190)
2023-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/packages#5209)
2023-10-25 [email protected] Replace gems dependency with ruby. (flutter/packages#5219)
2023-10-25 [email protected] Update the ftl hardware version. (flutter/packages#5224)
2023-10-25 [email protected] [ci] Disable Windows Arm64 stable CI (flutter/packages#5217)
2023-10-24 [email protected] [webview_flutter_wkwebview] Only set `limitsNavigationsToAppBoundDomains` when it is set to true (flutter/packages#5137)
2023-10-24 [email protected] [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5155)
2023-10-24 [email protected] [Android] Introduces API 34 emulators for subset of tests (flutter/packages#5105)
2023-10-24 [email protected] [url_launcher] Add an `inAppBrowserView` mode in implementations (flutter/packages#5211)
2023-10-24 [email protected] [ci] Fix legacy Android task names (flutter/packages#5191)
2023-10-24 [email protected] Update annotations deps to 1.7 (flutter/packages#4935)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[packages] Re-add integration testing with older Android

2 participants