[tool] Fix filter-packages-to when everything is changed
#5182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`filter-packages-to` didn't correctly the handle the case where the set of target packages is empty, meaning that all packages should be tested. This broke it for cases such as changing a CI configuration file, making the filter not take effect.
stuartmorgan-g
requested review from
bparrishMines,
camsim99,
ricardoamador and
tarrinneal
tarrinneal
approved these changes
Oct 19, 2023
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/5182, due to - The status or check suite Linux_android android_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
ricardoamador
approved these changes
Oct 19, 2023
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 20, 2023
flutter/packages@09c6b11...be915be 2023-10-20 [email protected] [ci] Finalize migration to x64 specific Windows platform (flutter/packages#5174) 2023-10-19 [email protected] [image_picker_ios] Update UITests for Xcode 15/iOS 17 (flutter/packages#5176) 2023-10-19 [email protected] [ci] Add emulator tests on older Android version (flutter/packages#4616) 2023-10-19 [email protected] Roll Flutter from 189196d to c2bd2c1 (11 revisions) (flutter/packages#5183) 2023-10-19 [email protected] [tool] Fix `filter-packages-to` when everything is changed (flutter/packages#5182) 2023-10-19 [email protected] [pigeon] add flutter api protocol (flutter/packages#5181) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter-packages-todidn't correctly the handle the case where the set of target packages is empty, meaning that all packages should be tested. This broke it for cases such as changing a CI configuration file, making the filter not take effect.