Skip to content

Conversation

@goderbauer
Copy link
Member

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 12, 2023

auto label is removed for flutter/packages/5122, due to - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 12, 2023

auto label is removed for flutter/packages/5122, due to - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 12, 2023

auto label is removed for flutter/packages/5122, due to - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2023
@auto-submit auto-submit bot merged commit 0dc8f4e into flutter:main Oct 12, 2023
@goderbauer goderbauer deleted the updateWebBenchmark branch October 12, 2023 16:30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 13, 2023
flutter/packages@93c3f69...fd84e65

2023-10-12 [email protected] [go_router] Fix missing build parameter in type-safe routes topic documentation (flutter/packages#5040)
2023-10-12 [email protected] Roll Flutter (stable) from ead4559 to 2f708eb (1 revision) (flutter/packages#5134)
2023-10-12 [email protected] [web_benchmarks] Bump process version constraints (flutter/packages#5122)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: web_benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants