Skip to content

Conversation

@tarrinneal
Copy link
Contributor

@tarrinneal tarrinneal commented Oct 10, 2023

Converts from direct use of method channels to using Pigeon.

Part of flutter/flutter#117844
part of flutter/flutter#117913

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@tarrinneal tarrinneal force-pushed the QA-pigeon branch 2 times, most recently from 62579ff to b294b3c Compare October 13, 2023 01:56
@tarrinneal tarrinneal changed the title Qa pigeon [quick_actions] Convert android to pigeon Oct 13, 2023
@tarrinneal tarrinneal marked this pull request as ready for review October 13, 2023 02:12
@tarrinneal tarrinneal requested a review from camsim99 as a code owner October 13, 2023 02:12
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2023
@auto-submit auto-submit bot merged commit e8127e7 into flutter:main Oct 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: quick_actions platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants