[two_dimensional_scrollables] Fix paint bug when rows/columns are pinned and axes are reversed #5038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
the
p: two_dimensional_scrollables
goderbauer
approved these changes
Oct 2, 2023
Member
There was a problem hiding this comment.
Just wondering why this one and the next one is included in this PR as "changed". Aren't they 100% identical?
Contributor
Author
There was a problem hiding this comment.
Yeah I was curious about this too. Probably really minor pixel diffs. Running flutter test --update-goldens output new images per git when I ran it for the new golden test here, so I figured I would let them be updated.
Comment on lines
1057
to
1062
| foregroundDecoration: const TableSpanDecoration( | ||
| border: TableSpanBorder( | ||
| trailing: BorderSide( | ||
| color: Colors.orange, | ||
| width: 3, | ||
| ))), |
Member
There was a problem hiding this comment.
formatting nit (probably just missing some trailing commas?):
Suggested change
| foregroundDecoration: const TableSpanDecoration( | |
| border: TableSpanBorder( | |
| trailing: BorderSide( | |
| color: Colors.orange, | |
| width: 3, | |
| ))), | |
| foregroundDecoration: const TableSpanDecoration( | |
| border: TableSpanBorder( | |
| trailing: BorderSide( | |
| color: Colors.orange, | |
| width: 3, | |
| ), | |
| ), | |
| ), |
Contributor
Author
There was a problem hiding this comment.
Good catch, I found a couple more cases of this, fixed them all. :)
| leading: BorderSide( | ||
| color: Colors.green, | ||
| width: 3, | ||
| ))), |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
… are pinned and axes are reversed (flutter/packages#5038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
… are pinned and axes are reversed (flutter/packages#5038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2023
… are pinned and axes are reversed (flutter/packages#5038)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 12, 2023
flutter/packages@4b483f2...93c3f69 2023-10-12 [email protected] [shared_preferences] update file version constraints (flutter/packages#5121) 2023-10-12 [email protected] [cross_file] Improved documentation about ignored parameters in IO module. (flutter/packages#4416) 2023-10-11 [email protected] [in_app_purchase] [#135759] Fix. doc reference finishPurchase to completePurchase. (flutter/packages#5081) 2023-10-10 [email protected] Update repo README issues link (flutter/packages#5106) 2023-10-10 [email protected] [flutter_markdown] Fix typo in readme (flutter/packages#5096) 2023-10-10 [email protected] [camerax] Implements torch mode (flutter/packages#4903) 2023-10-10 [email protected] [shared_preferences] fix documentation wording (flutter/packages#4986) 2023-10-10 [email protected] [two_dimensional_scrollables] Fix paint bug when rows/columns are pinned and axes are reversed (flutter/packages#5038) 2023-10-10 [email protected] Roll Flutter from f52fe4f to 83134ac (25 revisions) (flutter/packages#5104) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
… are reversed (#5916) Fixes flutter/flutter#141704 This fixes the rect computation for TableSpanDecorations when one or both axes are reversed. We previously fixed similar issues when the clipRects applied to areas of the table did not account for reversed. This is another similar case. - #5187 - #5038 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#135386
This adds one more golden to verify the painting, but once public mock_canvas rolls to stable in flutter_test, we can remove all of the goldens and just verify using the
paintsmethod.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.