[pigeon] FlutterApi error handling #5008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Since we have breaking changes to Java in this PR we should do the |
stuartmorgan-g
requested changes
Oct 2, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
All the new generated boilerplate makes me sad, but we can tackle that later. It great to have this plumbed correctly everywhere!
packages/pigeon/example/app/android/app/src/main/java/io/flutter/plugins/Messages.java
Outdated
Show resolved
Hide resolved
Collaborator
There was a problem hiding this comment.
Doesn't the [outputAsNumber integerValue] need to be cast to the enum type to avoid warnings?
Contributor
Author
There was a problem hiding this comment.
I don't think so, they're freely convertible from my understanding. 🤷
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 4, 2023
flutter/packages@c7008cf...d654f75 2023-10-04 [email protected] [pigeon] FlutterApi error handling (flutter/packages#5008) 2023-10-03 [email protected] [webview_flutter] [webview_flutter_wkwebview]Fix race condition in flaky test (flutter/packages#5068) 2023-10-03 [email protected] Roll Flutter from 57ed724 to 5122991 (21 revisions) (flutter/packages#5067) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@c7008cf...d654f75 2023-10-04 [email protected] [pigeon] FlutterApi error handling (flutter/packages#5008) 2023-10-03 [email protected] [webview_flutter] [webview_flutter_wkwebview]Fix race condition in flaky test (flutter/packages#5068) 2023-10-03 [email protected] Roll Flutter from 57ed724 to 5122991 (21 revisions) (flutter/packages#5067) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replyclass from all Java method returns.NullableResultclass for all nullable Java method returns.nilresponse on error.SetuptoSetUpin Objective-c.fixes flutter/flutter#118243
fixes flutter/flutter#118245
fixes flutter/flutter#124268
fixes flutter/flutter#135176
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.