[video_player] isCompleted event. #4923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
force-pushed
the
isCompleted
branch
from
82e0d1a to
17fcdd7
Compare
tarrinneal
commented
Sep 15, 2023
stuartmorgan-g
requested changes
Sep 16, 2023
stuartmorgan-g
approved these changes
Sep 18, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM
I suspect we'll need to tune edge cases for this state based on feedback from real-world use, but this looks good as a baseline for that.
Contributor
Author
Agreed, I'll keep an eye on it. |
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 20, 2023
flutter/packages@d4e2454...51e74b9 2023-09-19 [email protected] [ios_platform_images] Convert to Pigeon (flutter/packages#4945) 2023-09-19 [email protected] [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880) 2023-09-19 [email protected] Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter/packages#4947) 2023-09-18 [email protected] [go_router] Adds on exit (flutter/packages#4699) 2023-09-18 [email protected] [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713) 2023-09-18 [email protected] [file_selector] Fix unknown extensions on macOS (flutter/packages#4946) 2023-09-18 [email protected] [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587) 2023-09-18 [email protected] Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter/packages#4944) 2023-09-18 [email protected] [video_player] isCompleted event. (flutter/packages#4923) 2023-09-18 [email protected] [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881) 2023-09-18 [email protected] [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941) 2023-09-18 [email protected] Add dashboard link to README (flutter/packages#4902) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@d4e2454...51e74b9 2023-09-19 [email protected] [ios_platform_images] Convert to Pigeon (flutter/packages#4945) 2023-09-19 [email protected] [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880) 2023-09-19 [email protected] Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter/packages#4947) 2023-09-18 [email protected] [go_router] Adds on exit (flutter/packages#4699) 2023-09-18 [email protected] [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713) 2023-09-18 [email protected] [file_selector] Fix unknown extensions on macOS (flutter/packages#4946) 2023-09-18 [email protected] [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587) 2023-09-18 [email protected] Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter/packages#4944) 2023-09-18 [email protected] [video_player] isCompleted event. (flutter/packages#4923) 2023-09-18 [email protected] [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881) 2023-09-18 [email protected] [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941) 2023-09-18 [email protected] Add dashboard link to README (flutter/packages#4902) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
isCompletedevent toVideoPlayerEvent.fixes flutter/flutter#21929
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.