[image_picker] Fix link in README file. #4775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
approved these changes
Aug 28, 2023
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
tarrinneal
added
override: no versioning needed
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/4775, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
stuartmorgan-g
removed
override: no versioning needed
stuartmorgan-g
requested changes
Aug 29, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
- I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.- I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.
This is not exempt; please read the FAQ in the linked guide.
| Since the macOS implementation uses `file_selector`, you will need to | ||
| add a filesystem access | ||
| [entitlement][https://docs.flutter.dev/platform-integration/macos/building#entitlements-and-the-app-sandbox]: | ||
| [entitlement][3]: |
Collaborator
There was a problem hiding this comment.
These kind of link references are hard to maintain correctly in a long document; please use [entitlement](inline link), as with most of the rest of the README.
Contributor
Sorry about that. @stuartmorgan is correct. |
- use [title](inline link) instead of [title][label]
stuartmorgan-g
added
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/4775, due to - The status or check suite version_check has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 31, 2023
flutter/packages@64af59e...e7d812c 2023-08-30 [email protected] [path_provider] Fix93198: Added getDownloadsDirectory() for Android (flutter/packages#4708) 2023-08-30 [email protected] [in_app_purchase] Minor lint cleanup (flutter/packages#4818) 2023-08-30 [email protected] [local_auth] Update to pigeon 11 and remove enum wrappers (flutter/packages#4809) 2023-08-30 [email protected] [image_picker] Fix link in README file. (flutter/packages#4775) 2023-08-30 [email protected] [web] Use new APIs from `dart:ui_web` (flutter/packages#4168) 2023-08-30 [email protected] Roll Flutter from 6c95737 to 1fe2495 (24 revisions) (flutter/packages#4817) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect link formatting.
Before: [entitlement][https://docs.flutter.dev/platform-integration/macos/building#entitlements-and-the-app-sandbox]
After: entitlement
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.