[two_dimensional_scrollables][WIP] debug error from ParentDataWidget #4746
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
cc @goderbauer - not for review, just sharing for ParentDataWidget error case |
| /// Pinned cells cannot be merged with cells that are not pinned. | ||
| /// | ||
| /// If [columnMergeStart] is set, this must not be null. | ||
| int? columnMergeEnd; |
There was a problem hiding this comment.
on a side note, may I suggest a different api that relies on column span ?
maintaining one index (columnMergeStart) + a length (columnSpan)
is better than maintaining two indexes (columnMergeStart) + (columnMergeEnd)
since if the user wants to shift the merged cells, they only need to change the start index.
There was a problem hiding this comment.
Thanks for the feedback! That is a great idea.
I am going to close this for now while we look into making some changes in ParentDataWidget so unblock the issue that cropped up here.
2 participants
Super rough, was bringing over code from another branch and hit an error. Sharing for discussion/debugging.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.