[go_router] Fixes the GoRouter.goBranch so that it doesn't reset extr… #4723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
3 tasks
…a to null if extra is not serializable.
chunhtai
force-pushed
the
issues/129347
branch
from
7f4ea1f to
64a4deb
Compare
parlough
pushed a commit
to flutter/website
that referenced
this pull request
Sep 18, 2023
breaking change for flutter/packages#4723
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Sep 19, 2023
chunhtai
added
the
autosubmit
atsansone
pushed a commit
to flutter/website
that referenced
this pull request
Sep 21, 2023
breaking change for flutter/packages#4723
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 22, 2023
flutter/packages@d0411e4...98ebcd3 2023-09-22 [email protected] Manual roll Flutter (stable) from 367f9ea to 12fccda (2 revisions) (flutter/packages#4976) 2023-09-21 [email protected] [go_router] Fixes the GoRouter.goBranch so that it doesn't reset extr� (flutter/packages#4723) 2023-09-21 [email protected] [webview_flutter_wkwebview] Adds WKWebView implementation to override console log (flutter/packages#4703) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@d0411e4...98ebcd3 2023-09-22 [email protected] Manual roll Flutter (stable) from 367f9ea to 12fccda (2 revisions) (flutter/packages#4976) 2023-09-21 [email protected] [go_router] Fixes the GoRouter.goBranch so that it doesn't reset extr� (flutter/packages#4723) 2023-09-21 [email protected] [webview_flutter_wkwebview] Adds WKWebView implementation to override console log (flutter/packages#4703) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a to null if extra is not serializable.
This was a mistake I made when I refactor the code, the goBranch uses GoRouter.restore which will go through unnecessary serialize/deserialize. Fixing this will unfortunately introduce a breaking change, though I don't think a lot of people will be impacted by this.
I will write a migration guide soon
fixes flutter/flutter#129347
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.