Skip to content

Conversation

@tarrinneal
Copy link
Contributor

adds ability to run pigeon tests without regenerating code (to make iterating and testing easier).

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2023
@auto-submit auto-submit bot merged commit 6cc49a4 into flutter:main Aug 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 14, 2023
flutter/packages@9b15c2e...08080ab

2023-08-12 [email protected] [google_maps_flutter] removed old overrides (flutter/packages#4679)
2023-08-11 [email protected] [dynamic_layouts] Refactor flaky test (flutter/packages#4681)
2023-08-11 [email protected] [shared_preferences] Update iOS/macOS Pigeon (flutter/packages#4668)
2023-08-11 [email protected] [pigeon] skipGen (flutter/packages#4682)
2023-08-11 [email protected] Roll Flutter from 685141b to 9b6945b (25 revisions) (flutter/packages#4680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants