[google_maps_flutter] removed old overrides #4679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Thanks for your first contribution! Go ahead and sign the CLA for the flutter team to take a look at this pr. |
Contributor
Author
|
Hi, thank you! I signed yesterday and passed the cla/google check |
reidbaker
approved these changes
Aug 11, 2023
gmackall
approved these changes
Aug 11, 2023
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
LGTM, thanks for the cleanup!
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 14, 2023
flutter/packages@9b15c2e...08080ab 2023-08-12 [email protected] [google_maps_flutter] removed old overrides (flutter/packages#4679) 2023-08-11 [email protected] [dynamic_layouts] Refactor flaky test (flutter/packages#4681) 2023-08-11 [email protected] [shared_preferences] Update iOS/macOS Pigeon (flutter/packages#4668) 2023-08-11 [email protected] [pigeon] skipGen (flutter/packages#4682) 2023-08-11 [email protected] Roll Flutter from 685141b to 9b6945b (25 revisions) (flutter/packages#4680) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 2 overrides with the comment
As the issue was fixed in 2019
Related to flutter/flutter#131791
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.