[url_launcher_android] Set buildFeatures.buildConfig to true for compatibility with AGP 8.0+
#4535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
test-exempt: We can't test this until we have the right version of Java in CI; the plan is to look into rolling all our examples forward to 8 once we migrate Android tests to LUCI, since it should hopefully be easier to manage our Java version at that point. |
11 tasks
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2023
…e for compatibility with AGP 8.0+ (flutter/packages#4535)
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 21, 2023
flutter/packages@674179f...2266a76 2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525) 2023-07-20 [email protected] [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535) 2023-07-20 [email protected] [go_router] fix error handling page link (flutter/packages#4296) 2023-07-20 [email protected] [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534) 2023-07-20 [email protected] [ci] Simplify Dockerfile (flutter/packages#4530) 2023-07-20 [email protected] [ci] Enable Windows Dart unit test sharding (flutter/packages#4528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@674179f...2266a76 2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525) 2023-07-20 [email protected] [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535) 2023-07-20 [email protected] [go_router] fix error handling page link (flutter/packages#4296) 2023-07-20 [email protected] [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534) 2023-07-20 [email protected] [ci] Simplify Dockerfile (flutter/packages#4530) 2023-07-20 [email protected] [ci] Enable Windows Dart unit test sharding (flutter/packages#4528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
….0+ (#4951) Fixes flutter/flutter#134818 See #4535 for an example of when this was done for a different plugin.
2 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag controls the generation of the BuildConfig class, which is used to guard a log line.
In AGP 7.x this flag defaulted to true. AGP 8.x changed it to default to false. This PR sets it explicitly to true, so we don't rely on defaults, and fixes an error for people using AGP 8.0+. I also upgraded an old AGP version while I was at it.
Fixes flutter/flutter#128204.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.