-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[various] Deletes deprecated splash screen meta-data element #4501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gmackall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I think this caused the tree to fail https://github.com/flutter/packages/runs/15141527296 |
I think that was an unrelated flake. Re-ran it and it passed. |
flutter/packages@3e8b813...209db21 2023-07-19 [email protected] [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473) 2023-07-19 [email protected] Manual roll Flutter from f842ed9 to 6f09064 (11 revisions) (flutter/packages#4518) 2023-07-19 [email protected] [ci] Enable new sharding (flutter/packages#4515) 2023-07-19 [email protected] [flutter_markdown] Change the way tests get screen size (flutter/packages#4514) 2023-07-18 [email protected] [ci] Roll Flutter to f842ed9 (flutter/packages#4513) 2023-07-18 [email protected] [image_picker] Update Android example (flutter/packages#4504) 2023-07-18 [email protected] [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511) 2023-07-18 [email protected] [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@3e8b813...209db21 2023-07-19 [email protected] [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473) 2023-07-19 [email protected] Manual roll Flutter from f842ed9 to 6f09064 (11 revisions) (flutter/packages#4518) 2023-07-19 [email protected] [ci] Enable new sharding (flutter/packages#4515) 2023-07-19 [email protected] [flutter_markdown] Change the way tests get screen size (flutter/packages#4514) 2023-07-18 [email protected] [ci] Roll Flutter to f842ed9 (flutter/packages#4513) 2023-07-18 [email protected] [image_picker] Update Android example (flutter/packages#4504) 2023-07-18 [email protected] [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511) 2023-07-18 [email protected] [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Deletes deprecated splash screen meta-data element.
This is no longer needed to present a splash screen in a Flutter application, but will be removed soon. See go/flutter-splash-screen-migration for more information.
Part of flutter/flutter#105173.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).