Skip to content

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jul 17, 2023

Deletes deprecated splash screen meta-data element.

This is no longer needed to present a splash screen in a Flutter application, but will be removed soon. See go/flutter-splash-screen-migration for more information.

Part of flutter/flutter#105173.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@camsim99 camsim99 marked this pull request as ready for review July 18, 2023 17:08
@camsim99 camsim99 requested a review from a team July 18, 2023 17:09
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@auto-submit auto-submit bot merged commit 1fd191e into flutter:main Jul 18, 2023
@reidbaker
Copy link
Contributor

@camsim99
Copy link
Contributor Author

I think this caused the tree to fail https://github.com/flutter/packages/runs/15141527296

I think that was an unrelated flake. Re-ran it and it passed.

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2023
flutter/packages@3e8b813...209db21

2023-07-19 [email protected] [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473)
2023-07-19 [email protected] Manual roll Flutter from f842ed9 to 6f09064 (11 revisions) (flutter/packages#4518)
2023-07-19 [email protected] [ci] Enable new sharding (flutter/packages#4515)
2023-07-19 [email protected] [flutter_markdown] Change the way tests get screen size (flutter/packages#4514)
2023-07-18 [email protected] [ci] Roll Flutter to f842ed9 (flutter/packages#4513)
2023-07-18 [email protected] [image_picker] Update Android example (flutter/packages#4504)
2023-07-18 [email protected] [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511)
2023-07-18 [email protected] [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
flutter/packages@3e8b813...209db21

2023-07-19 [email protected] [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473)
2023-07-19 [email protected] Manual roll Flutter from f842ed9 to 6f09064 (11 revisions) (flutter/packages#4518)
2023-07-19 [email protected] [ci] Enable new sharding (flutter/packages#4515)
2023-07-19 [email protected] [flutter_markdown] Change the way tests get screen size (flutter/packages#4514)
2023-07-18 [email protected] [ci] Roll Flutter to f842ed9 (flutter/packages#4513)
2023-07-18 [email protected] [image_picker] Update Android example (flutter/packages#4504)
2023-07-18 [email protected] [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511)
2023-07-18 [email protected] [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: flutter_markdown p: shared_preferences platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants