Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Jul 16, 2023

The only package that was using the equatable package removed it, so we no longer need this allowance.

The only package depending on xml was flutter_migrate, but it never actually used it, so that can be removed as well.

Part of flutter/flutter#122713

The only package that was using the `equtable` package removed it, so we
no longer need this allowance.

Part of flutter/flutter#122713
@stuartmorgan-g stuartmorgan-g changed the title Remove 'equatable' allowance Remove equatable and xml allowances Jul 16, 2023
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@auto-submit auto-submit bot merged commit dc41ccc into flutter:main Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 18, 2023
flutter/packages@6889cca...3e8b813

2023-07-18 [email protected] [video_player] Fix iOS crash with multiple players (flutter/packages#4202)
2023-07-17 [email protected] [pigeon] Enable Android emulator tests in CI (flutter/packages#4484)
2023-07-17 [email protected] [video_player] Add optional web options [Platform interface] (flutter/packages#4433)
2023-07-17 [email protected] [google_maps_flutter_platform_interface] Platform interface changes for #3258 (flutter/packages#4478)
2023-07-17 [email protected] [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826)
2023-07-17 [email protected] [camerax] Add flash configuration for image capture (flutter/packages#3800)
2023-07-17 [email protected] Remove `equatable` and `xml` allowances (flutter/packages#4489)
2023-07-17 [email protected] [ci] Switch Linux platform tests to LUCI (flutter/packages#4479)
2023-07-17 [email protected] [ci] Adjust bot configurations (flutter/packages#4485)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
flutter/packages@6889cca...3e8b813

2023-07-18 [email protected] [video_player] Fix iOS crash with multiple players (flutter/packages#4202)
2023-07-17 [email protected] [pigeon] Enable Android emulator tests in CI (flutter/packages#4484)
2023-07-17 [email protected] [video_player] Add optional web options [Platform interface] (flutter/packages#4433)
2023-07-17 [email protected] [google_maps_flutter_platform_interface] Platform interface changes for flutter#3258 (flutter/packages#4478)
2023-07-17 [email protected] [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826)
2023-07-17 [email protected] [camerax] Add flash configuration for image capture (flutter/packages#3800)
2023-07-17 [email protected] Remove `equatable` and `xml` allowances (flutter/packages#4489)
2023-07-17 [email protected] [ci] Switch Linux platform tests to LUCI (flutter/packages#4479)
2023-07-17 [email protected] [ci] Adjust bot configurations (flutter/packages#4485)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: flutter_migrate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants