You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am about to land a migrator in flutter/flutter which will upgrade minSdkVersions in app-level build.gradle files to 19, but want to make these changes to the packages repo ahead of time. It ended up only mattering in one place though, from what I can tell.
I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
I am about to land a migrator in flutter/flutter which will upgrade minSdkVersions in app-level build.gradle files to 19, but want to make these changes to the packages repo ahead of time.
We support stable, which still supports pre-19; wouldn't it make more sense to wait until stable is 19+, and then update packages? That's how we did the last iOS support drop.
I am about to land a migrator in flutter/flutter which will upgrade minSdkVersions in app-level build.gradle files to 19, but want to make these changes to the packages repo ahead of time.
We support stable, which still supports pre-19; wouldn't it make more sense to wait until stable is 19+, and then update packages? That's how we did the last iOS support drop.
Thanks for pointing this out, yes that does make more sense. My mistake!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am about to land a migrator in flutter/flutter which will upgrade
minSdkVersions in app-level build.gradle files to 19, but want to make these changes to the packages repo ahead of time. It ended up only mattering in one place though, from what I can tell.Migrator PR here: flutter/flutter#129729
Part of flutter/flutter#82000
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.