[go_router] fix(docs): improve docs and fix typo #4414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
chunhtai
reviewed
Jul 10, 2023
Contributor
There was a problem hiding this comment.
I can't tell what has changed in this line. is there a hidden magic here?
Contributor
There was a problem hiding this comment.
Hi @sdoshi983 can you revert this change if there is indeed nothing change?
Contributor
Author
There was a problem hiding this comment.
hey @chunhtai, yes you are correct. There was no change. As suggested by you:
- I have signed the CLA
- I have reverted the change.
Please let me know in case of any other changes
Contributor
|
you will need to sign the CLA before contributing to flutter |
chunhtai
added
override: no versioning needed
Contributor
|
no version change or change log needed. Reason: this is a typo fix that doesn't impact the readability too much. |
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 27, 2023
flutter/packages@a99fc87...f4ae933 2023-07-27 [email protected] Manual roll Flutter from bae1ac2 to 61fd11d (7 revisions) (flutter/packages#4572) 2023-07-26 [email protected] Roll Flutter from 9def8f6 to bae1ac2 (27 revisions) (flutter/packages#4570) 2023-07-26 [email protected] [go_router] fix(docs): improve docs and fix typo (flutter/packages#4414) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@a99fc87...f4ae933 2023-07-27 [email protected] Manual roll Flutter from bae1ac2 to 61fd11d (7 revisions) (flutter/packages#4572) 2023-07-26 [email protected] Roll Flutter from 9def8f6 to bae1ac2 (27 revisions) (flutter/packages#4570) 2023-07-26 [email protected] [go_router] fix(docs): improve docs and fix typo (flutter/packages#4414) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
flutter/packages@a99fc87...f4ae933 2023-07-27 [email protected] Manual roll Flutter from bae1ac2 to 61fd11d (7 revisions) (flutter/packages#4572) 2023-07-26 [email protected] Roll Flutter from 9def8f6 to bae1ac2 (27 revisions) (flutter/packages#4570) 2023-07-26 [email protected] [go_router] fix(docs): improve docs and fix typo (flutter/packages#4414) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all maintainers,
I was going through the documentation of go_router package. In the configuration topic, I found a sentence that might not be conveying the actual meaning to the reader.
As I faced the same issue, I would like to take the opportunity to improve it and contribute for the same. Is the change valid? Do let me know in case of any improvements
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.